Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

utybo
Copy link
Contributor

@utybo utybo commented Dec 29, 2023

Fixes #988

Use cross-spawn instead of the regular Node spawn. No tests added because the tests were already failing on Windows.

@utybo utybo changed the title fix(test): use cross-spawn to npm on windows work fix(test): use cross-spawn to make npm on windows work Jan 2, 2024
@isaacs
Copy link
Member

isaacs commented Jan 19, 2024

Is cross-spawn still needed? I feel like the issue in #989 is probably just a matter of missing a shell: true somewhere.

isaacs added a commit that referenced this pull request Jan 19, 2024
Re: #988

Similar to #990, but without adding cross-spawn as a dep.
@isaacs
Copy link
Member

isaacs commented Jan 19, 2024

Running #958 with an update to use shell: true in a few places, if that passes, I'll land that and close this one. Better to save the extra dep, if possible. Keeping this open until then, since it might still be needed, should know soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Unable to generate test class on Windows (test class generation script bugs)

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.