Merge suggestions when using @utility
#18900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When existing suggestions exist, and you have a custom `@utility` with a matching root, then we would override the existing utilities which is wrong. This ensures that we merge all the groups such that all utilities are being suggested to the user.
For the `mask-*` utilities, we do call `suggest(…)` multiple times, so there could be some duplication. The `modifiers` are a simple array and not a Set so let's make them unique here. Ideally we don't call suggest with the same values, but that requires a bigger internal refactor. Another ideal situation would be if `modifiers` was a Set in the first place. But since it's export and "public" API I didn't want to change that datastructure.
ba07e94 to
fe9acb3
Compare
philipp-spiess
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where custom
@utilityimplementations with a name that match an existing utility would override the existing suggestions even though we generate both utilities.With this, we want to make sure that both the custom and the built-in utilities are suggested. We also want to make sure that we don't get duplicate suggestions.
E.g.:
font-would suggest:But if you introduce this little custom utility:
font-would suggest:With this fix, we would suggest:
font-would suggest:We also make sure that they are unique, so if you have a custom utility that happens to match another existing utility (e.g.
font-bold), you won't seefont-boldtwice in the suggestions.font-would suggest: