[Example] Cast index to int in comet.py to resolve TaichiWarning#8597
Open
bluevisor wants to merge 1 commit intotaichi-dev:mastertaichi-dev/taichi:masterfrom
Open
[Example] Cast index to int in comet.py to resolve TaichiWarning#8597bluevisor wants to merge 1 commit intotaichi-dev:mastertaichi-dev/taichi:masterfrom
bluevisor wants to merge 1 commit intotaichi-dev:mastertaichi-dev/taichi:masterfrom
Conversation
Explicitly cast index `i` to int in `ti.deactivate` to prevent TaichiWarning
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #
This PR addresses a Taichi warning in
comet.pyby explicitly castingito an integer in theti.deactivatefunction. The warning appeared as follows:TaichiWarning While compiling substep_c76_0, File “taichi/examples/simulation/comet.py”, line 55, in substep: ti.deactivate(x.snode.parent(), [i]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Field index 0 not int32, casting into int32 implicitlyChanges Made
ti.deactivate(x.snode.parent(), [i])toti.deactivate(x.snode.parent(), [int(i)])incomet.py.Rationale
Explicitly casting
itointprevents Taichi from implicitly casting and suppresses the TaichiWarning. This change improves code clarity and ensures compatibility with the expected data type for the function.Testing
comet.py.comet.pyremains intact after this change.