Basic tests for request making methods#91
Merged
t8y8 merged 1 commit intotableau:developmenttableau/server-client-python:developmentfrom Nov 2, 2016
Merged
Basic tests for request making methods#91t8y8 merged 1 commit intotableau:developmenttableau/server-client-python:developmentfrom
t8y8 merged 1 commit intotableau:developmenttableau/server-client-python:developmentfrom
Conversation
graysonarts
approved these changes
Nov 2, 2016
Contributor
graysonarts
left a comment
There was a problem hiding this comment.
thanks, this kind of test will have definitely caught the problem I introduced. Thanks for doing this!
t8y8
added a commit
to t8y8/server-client-python
that referenced
this pull request
Jun 28, 2017
* GET and POST tests verify headers, body, and query strings coming from `Endpoint`
t8y8
added a commit
to t8y8/server-client-python
that referenced
this pull request
Jun 28, 2017
* GET and POST tests verify headers, body, and query strings coming from `Endpoint`
bryceglarsen
pushed a commit
to bryceglarsen/server-client-python
that referenced
this pull request
Dec 28, 2023
bryceglarsen
pushed a commit
to bryceglarsen/server-client-python
that referenced
this pull request
Dec 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A very early and very primitive set of tests that would have covered #88 .
Basically, make a request (we match on any endpoint because the response doesn't matter) then peek into the request object and assert it all came together correctly.
/cc @RussTheAerialist