Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

841 enhancement rename datasource#843

Merged
shinchris merged 4 commits intotableau:developmenttableau/server-client-python:developmentfrom
annematronic:841-enhancement-rename-datasourceannematronic/server-client-python:841-enhancement-rename-datasourceCopy head branch name to clipboard
May 25, 2021
Merged

841 enhancement rename datasource#843
shinchris merged 4 commits intotableau:developmenttableau/server-client-python:developmentfrom
annematronic:841-enhancement-rename-datasourceannematronic/server-client-python:841-enhancement-rename-datasourceCopy head branch name to clipboard

Conversation

@annematronic
Copy link
Contributor

@annematronic annematronic commented May 5, 2021

Changes include:

  • Update request factory to add name attribute when present.
  • Update Datasource tests to assert name (and some other properties that were not already asserted)
  • Updated other Datasource tests which were passing 'project_id' and 'name' in the incorrect order to the DatasourceItem constructor

shinchris
shinchris reviewed May 24, 2021
View reviewed changes
Copy link
Contributor

@shinchris shinchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment in test, but otherwise looks good!

test/test_datasource.py Outdated Show resolved Hide resolved
@shinchris shinchris merged commit 5d333f5 into tableau:development May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shinchris shinchris shinchris approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla:signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@annematronic @shinchris @jacalata
Morty Proxy This is a proxified and sanitized view of the page, visit original site.