Fixes default permissions urls and adds return value to update endpoints#603
Merged
shinchris merged 3 commits intodevelopmenttableau/server-client-python:developmentfrom May 1, 2020
default_permissionstableau/server-client-python:default_permissionsCopy head branch name to clipboard
Merged
Fixes default permissions urls and adds return value to update endpoints#603shinchris merged 3 commits intodevelopmenttableau/server-client-python:developmentfrom default_permissionstableau/server-client-python:default_permissionsCopy head branch name to clipboard
shinchris merged 3 commits intodevelopmenttableau/server-client-python:developmentfrom
default_permissionstableau/server-client-python:default_permissionsCopy head branch name to clipboard
Conversation
Contributor
Author
|
I'm also adding some samples. Will push it as soon as it's done. |
t8y8
approved these changes
Apr 29, 2020
Collaborator
t8y8
left a comment
There was a problem hiding this comment.
Can you verify it runs on a real server internally (one with Catalog enabled?) -- I'm 99% sure I did back in the day but apparently I missed something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default permissions urls for update and delete were missing an 's' after the content types. Also noticed that the update permission methods weren't returning the response from server, while the delete methods were unnecessarily returning something.
Changes: