Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Create notes property from XML response#571

Merged
t8y8 merged 3 commits intotableau:developmenttableau/server-client-python:developmentfrom
jorwoods:jorwoods/JobItem_notesjorwoods/server-client-python:jorwoods/JobItem_notesCopy head branch name to clipboard
Jul 21, 2020
Merged

Create notes property from XML response#571
t8y8 merged 3 commits intotableau:developmenttableau/server-client-python:developmentfrom
jorwoods:jorwoods/JobItem_notesjorwoods/server-client-python:jorwoods/JobItem_notesCopy head branch name to clipboard

Conversation

@jorwoods
Copy link
Contributor

@jorwoods jorwoods commented Feb 20, 2020

Adds note information to JobItem objects. Should resolve #564

t8y8
t8y8 reviewed May 12, 2020
View reviewed changes
Copy link
Collaborator

@t8y8 t8y8 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good -- can you add a test as well?

@jorwoods (and have you submitted the CLA?)

@jorwoods jorwoods force-pushed the jorwoods/JobItem_notes branch 2 times, most recently from bcb8147 to fe16e6b Compare May 16, 2020 18:34
@jorwoods jorwoods force-pushed the jorwoods/JobItem_notes branch from fe16e6b to fc2e693 Compare May 16, 2020 18:38
@jorwoods
Copy link
Contributor Author

jorwoods commented May 16, 2020

Added a test for the notes property

@t8y8 t8y8 self-assigned this Jul 21, 2020
@t8y8
Copy link
Collaborator

t8y8 commented Jul 21, 2020

Hey @jorwoods sorry for forever delays, open source 🤦 .

On a re-review, I realized that the note value and type can be very interesting depending on the job -- I'm thinking of cases that want to programmatically take action based on the value, which is more stable that the note text.

What do you think about a simple NoteItem class, or at least a dictionary that holds some of the other attributes on the note element?

@jorwoods
Copy link
Contributor Author

jorwoods commented Jul 21, 2020 •
edited
Loading

What else can the note element contain besides text? statusNotes which is a different element can have other attributes, but for the purposes of solving the problem stated in the issue, as well as the problem I was trying to solve, those were contained with the notes.text() instead of somewhere within statusNotes.

@t8y8
Copy link
Collaborator

t8y8 commented Jul 21, 2020

Ah-ha, you're right, I've confused the note with the statusNote. I feel like I was PM back when we added this to the API, so I can only blame myself for the overlapping names.

t8y8
t8y8 suggested changes Jul 21, 2020
View reviewed changes
Copy link
Collaborator

@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit then looks good

tableauserverclient/models/job_item.py Outdated Show resolved Hide resolved
t8y8
t8y8 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Collaborator

@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@t8y8 t8y8 merged commit f972ea6 into tableau:development Jul 21, 2020
rshide pushed a commit to rshide/server-client-python that referenced this pull request Aug 11, 2020
@jorwoods
Create notes property from XML response (tableau#571)
5a2df0b 
Create notes property from XML response

Co-authored-by: Jordan Woods <Jordan.Woods@mkcorp.com>
shinchris pushed a commit that referenced this pull request Aug 14, 2020
@rshide @jorwoods @bcantoni
Added webpage url to workbooks (#661)
0133207 
* Fixes login sample to pass in sitename for username/password auth

(cherry picked from commit 4cbd800)

* Fixes default sitename in login sample and adds more print statements (#652)


(cherry picked from commit ccbbc49)

* Updates changelog with patch notes

* Added webpage_url to workbooks

* removed vscode files

* Update workbook_item.py

Removing whitespace

* Update test_workbook.py

Removing cells

* Update test_workbook.py

Removing whitespace

* Update workbook_get_by_id.xml

Adding webpage url

* Create notes property from XML response (#571)

Create notes property from XML response

Co-authored-by: Jordan Woods <Jordan.Woods@mkcorp.com>

* Minor edits and cleanup

* Rename a duplicate test method so they all run

* Cleanup test comments and descriptions, no functional changes

* Add support for Python 3.8

Only test_publish_with_hidden_view() needed changes because the order of
attributes in the XML request body were swapped for some reason in 3.8
compared to prior Pythons.

Co-authored-by: Chris Shin <cshin@tableau.com>
Co-authored-by: Rickey Shideler <rickey.shideler.jr@walmart.com>
Co-authored-by: jorwoods <jorwoods@users.noreply.github.com>
Co-authored-by: Jordan Woods <Jordan.Woods@mkcorp.com>
Co-authored-by: Brian Cantoni <bcantoni@tableau.com>
shinchris pushed a commit that referenced this pull request Sep 1, 2020
Updates changelog and contributors file for v0.13 (#684)
2229843 
* Added notes field to JobItem (#571)
* Added webpage_url field to WorkbookItem (#661)
* Added support for switching between sites (#655)
* Added support for querying favorites for a user (#656)
* Added support for Python 3.8 (#659)
* Added support for Data Alerts (#667)
* Added support for basic Extract operations - Create, Delete, en/re/decrypt for site (#672)
* Added support for creating and querying Active Directory groups (#674)
* Added support for asynchronously updating a group (#674)
* Improved handling of invalid dates (#529)
* Improved consistency of update_permission endpoints (#668)
* Documentation updates (#658, #669, #670, #673, #683)
@shinchris shinchris mentioned this pull request Sep 1, 2020
Merged
shinchris pushed a commit that referenced this pull request Sep 2, 2020
Merge pull request #685 from tableau/development
273af7a 
[v0.13] Merge development into master

Added notes field to JobItem (#571)
Added webpage_url field to WorkbookItem (#661)
Added support for switching between sites (#655)
Added support for querying favorites for a user (#656)
Added support for Python 3.8 (#659)
Added support for Data Alerts (#667)
Added support for basic Extract operations - Create, Delete, en/re/decrypt for site (#672)
Added support for creating and querying Active Directory groups (#674)
Added support for asynchronously updating a group (#674)
Improved handling of invalid dates (#529)
Improved consistency of update_permission endpoints (#668)
Documentation updates (#658, #669, #670, #673, #683)
jorwoods added a commit to jorwoods/server-client-python that referenced this pull request Feb 18, 2021
@jorwoods
Squashed commit of the following:
7efb7a6 
commit 2609e27
Merge: d107c48 3a8ec6c
Author: Chris Shin <cshin@tableau.com>
Date:   Wed Feb 17 16:00:42 2021 -0800

    Merge pull request tableau#803 from tableau/release-0.15

    syncing development branch with v0.15 changelog

commit d107c48
Author: Tyler Doyle <doyle.tyler@gmail.com>
Date:   Wed Feb 17 15:38:14 2021 -0800

    Add Mypy to CI runs (tableau#802)

    Add mypy runs to CI, but skip misc errors, so we only see the important stuff. For now these are non blocking.

commit 3a8ec6c
Merge: 004ab31 a5b9252
Author: Chris Shin <cshin@tableau.com>
Date:   Tue Feb 16 16:51:37 2021 -0800

    Merge branch 'master' into release-0.15

commit 004ab31
Author: Chris Shin <cshin@tableau.com>
Date:   Tue Feb 16 16:49:19 2021 -0800

    Updates changelog and contributors list for v0.15

commit 6c7a87b
Author: Chris Shin <cshin@tableau.com>
Date:   Tue Feb 16 15:09:45 2021 -0800

    Removes travis and adds linting/testing into github action (tableau#798)

    * Removes travis and adds github workflow

    * Addressing code review feedback

commit 9179637
Author: Lee Boynton <lee@lboynton.com>
Date:   Tue Feb 16 23:09:22 2021 +0000

    Add support for getting groups that a user belongs to (tableau#799)

    * Add support for getting groups that a user belongs to

    * Use more descriptive name for pager function

commit fe992ee
Author: Chris Shin <cshin@tableau.com>
Date:   Tue Feb 16 14:33:59 2021 -0800

    [Tasks] Translate task type from server to TSC enum (tableau#796)

    * Adds task type mapping to translate server response

    * Updates tests to match server response for task type

    * Fixes pycodestyle error

commit f64fcf9
Author: John Vandenberg <jayvdb@gmail.com>
Date:   Wed Feb 17 01:21:46 2021 +0800

    MANIFEST.in: Add docs and test data (tableau#780)

    * Update publish_workbook.py (tableau#694)

    * Update publish_workbook.py

    Added below arguments, without this there is a sign-in error on publishing a test file to Tableau Online

    parser.add_argument('--sitename', '-S', default='', help='sitename required')
    tableau_auth = TSC.TableauAuth(args.username, password,site_id=args.sitename)

    * Update publish_workbook.py

    Edits (as requested) to publish workbooks on Tableau Online which removes the Sign-in Error.

    * Update publish_workbook.py

    * Merge pull request tableau#745 from tableau/fix_732

    Server versions before 2020.1 do not accept encoded query param delimiters

    * Merge pull request tableau#757 from tableau/fix_754

    Fixes issue tableau#754 by moving file read logic inside generator

    * Updates changelog for v0.14.1

    * MANIFEST.in: Add docs and test data

    Closes tableau#779

    Co-authored-by: Chris Shin <cshin@tableau.com>
    Co-authored-by: Madhura Selvarajan <MADHURA0910@GMAIL.COM>

commit 88a0188
Author: Chris Shin <cshin@tableau.com>
Date:   Tue Feb 16 09:17:35 2021 -0800

    [Subscriptions] Add new fields and ability to update (tableau#794)

    * Add fields and parsing logic

    * Update subscription create request

    * Adds update request to subscriptions

    * Changes subscription change request creation to use tsrequest annotation

    * Update tests for parsing new fields

    * Fixes codestyle issues

    * Removes user and schedule name

    * Fixes test failure

commit 026bca8
Author: Chris Shin <cshin@tableau.com>
Date:   Thu Feb 11 15:34:08 2021 -0800

    Adds skipConnectionCheck to publish workbook (tableau#791)

    * Adds skipConnectionCheck flag to publish workbook

    * Removes unnecessary lines

    * Fixes style error

commit 857199b
Author: tjones-commits <70481977+tjones-commits@users.noreply.github.com>
Date:   Fri Feb 5 17:09:32 2021 -0500

    Update site properties and functions (tableau#777)

    * Update publish_workbook.py (tableau#694)

    * Update publish_workbook.py

    Added below arguments, without this there is a sign-in error on publishing a test file to Tableau Online

    parser.add_argument('--sitename', '-S', default='', help='sitename required')
    tableau_auth = TSC.TableauAuth(args.username, password,site_id=args.sitename)

    * Update publish_workbook.py

    Edits (as requested) to publish workbooks on Tableau Online which removes the Sign-in Error.

    * Update publish_workbook.py

    * Merge pull request tableau#745 from tableau/fix_732

    Server versions before 2020.1 do not accept encoded query param delimiters

    * Merge pull request tableau#757 from tableau/fix_754

    Fixes issue tableau#754 by moving file read logic inside generator

    * Updates changelog for v0.14.1

    * update the site item to reflect api response

    * update test model

    * remove extra test assets

    * trimming line length

    * unit test all properties. fix some properties. Remove extra code

    * make requested changes

    * make requested changes

    Co-authored-by: Chris Shin <cshin@tableau.com>
    Co-authored-by: Madhura Selvarajan <MADHURA0910@GMAIL.COM>
    Co-authored-by: Terrence Jones <tjones@arkatechture.com>

commit a5b9252
Merge: bcb881c 1fc349c
Author: Chris Shin <cshin@tableau.com>
Date:   Thu Dec 10 09:29:42 2020 -0800

    Merge pull request tableau#759 from tableau/0.14.0-patch

    v0.14.1 patch release
    * Fixed filter query issue for server version below 2020.1 (tableau#745)
    * Fixed large workbook/datasource publish issue (tableau#757)

commit 1fc349c
Author: Chris Shin <cshin@tableau.com>
Date:   Wed Dec 9 16:30:03 2020 -0800

    Updates changelog for v0.14.1

commit 41fd8f2
Author: Chris Shin <cshin@tableau.com>
Date:   Wed Dec 9 15:49:48 2020 -0800

    Merge pull request tableau#757 from tableau/fix_754

    Fixes issue tableau#754 by moving file read logic inside generator

commit 138476f
Author: Chris Shin <cshin@tableau.com>
Date:   Wed Dec 9 15:49:23 2020 -0800

    Merge pull request tableau#745 from tableau/fix_732

    Server versions before 2020.1 do not accept encoded query param delimiters

commit bcb881c
Merge: 8d51355 1e089b4
Author: Chris Shin <cshin@tableau.com>
Date:   Mon Nov 9 09:19:23 2020 -0800

    Merge pull request tableau#725 from tableau/development

    Syncing master with v0.14.0 changes from development.

commit 8d51355
Author: Madhura Selvarajan <MADHURA0910@GMAIL.COM>
Date:   Wed Sep 23 10:45:27 2020 -0400

    Update publish_workbook.py (tableau#694)

    * Update publish_workbook.py

    Added below arguments, without this there is a sign-in error on publishing a test file to Tableau Online

    parser.add_argument('--sitename', '-S', default='', help='sitename required')
    tableau_auth = TSC.TableauAuth(args.username, password,site_id=args.sitename)

    * Update publish_workbook.py

    Edits (as requested) to publish workbooks on Tableau Online which removes the Sign-in Error.

    * Update publish_workbook.py

commit 273af7a
Merge: 43e1b06 168489c
Author: Chris Shin <cshin@tableau.com>
Date:   Wed Sep 2 14:39:13 2020 -0700

    Merge pull request tableau#685 from tableau/development

    [v0.13] Merge development into master

    Added notes field to JobItem (tableau#571)
    Added webpage_url field to WorkbookItem (tableau#661)
    Added support for switching between sites (tableau#655)
    Added support for querying favorites for a user (tableau#656)
    Added support for Python 3.8 (tableau#659)
    Added support for Data Alerts (tableau#667)
    Added support for basic Extract operations - Create, Delete, en/re/decrypt for site (tableau#672)
    Added support for creating and querying Active Directory groups (tableau#674)
    Added support for asynchronously updating a group (tableau#674)
    Improved handling of invalid dates (tableau#529)
    Improved consistency of update_permission endpoints (tableau#668)
    Documentation updates (tableau#658, tableau#669, tableau#670, tableau#673, tableau#683)
@jacalata jacalata mentioned this pull request Nov 8, 2021
Closed
@jorwoods jorwoods deleted the jorwoods/JobItem_notes branch March 25, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@t8y8 t8y8 t8y8 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@t8y8 t8y8

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jorwoods @t8y8
Morty Proxy This is a proxified and sanitized view of the page, visit original site.