Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Adding support for 'getWorkbookPdf' endpoint of REST API#376

Merged
shinchris merged 1 commit intodevelopmenttableau/server-client-python:developmentfrom
workbook_pdftableau/server-client-python:workbook_pdfCopy head branch name to clipboard
Jan 30, 2019
Merged

Adding support for 'getWorkbookPdf' endpoint of REST API#376
shinchris merged 1 commit intodevelopmenttableau/server-client-python:developmentfrom
workbook_pdftableau/server-client-python:workbook_pdfCopy head branch name to clipboard

Conversation

@shinchris
Copy link
Contributor

No description provided.

Copy link
Contributor

@graysonarts graysonarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

def id(self):
return self._id

@property
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you remember why we did this pattern of lazy population?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many moons ago, it was because we didn't want to "make any calls the user didn't ask for".

Originally it populated a static list for things like Views in Workbooks; but when we needed paging for nested lists (Users in Groups), I converted everything to an on-demand function call; sometimes this is nice because you can filter or change the paging parameters of nested items. I didn't take it the whole way to making the property take request options and handling all of them to just hidden on-demand calls. Lee had some qualms about mixing requests and models, if I recall. Here, where I bind a secret function to the property was as far as we got :P

@shinchris shinchris merged commit 68a5159 into development Jan 30, 2019
@shinchris shinchris deleted the workbook_pdf branch January 30, 2019 20:57
@graysonarts graysonarts mentioned this pull request Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.