Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

adding basestring conversion to str for python3#362

Merged
shinchris merged 1 commit intodevelopmenttableau/server-client-python:developmentfrom
basestring_fixtableau/server-client-python:basestring_fixCopy head branch name to clipboard
Nov 15, 2018
Merged

adding basestring conversion to str for python3#362
shinchris merged 1 commit intodevelopmenttableau/server-client-python:developmentfrom
basestring_fixtableau/server-client-python:basestring_fixCopy head branch name to clipboard

Conversation

@shinchris
Copy link
Contributor

Addressing #351 where the usage of basestring would cause errors in python 3

Copy link
Collaborator

@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shinchris shinchris merged commit cdb0f67 into development Nov 15, 2018
@shinchris shinchris deleted the basestring_fix branch November 15, 2018 23:29
@thagraybush
Copy link

I downloaded TSC via pip only a few weeks ago and did NOT come with this fix for python 3. Still errors out with basestring issue you fixed @shinchris. Had come up with same and came here to create pull request to add but glad to see fixed. Why is this fix not coming when download latest via pip?

@shinchris
Copy link
Contributor Author

@thagraybush This fix was merged into the 'development' branch, waiting to be released into 'master' with version 0.8. When you downloaded TSC via pip a few weeks ago, we were still on version 0.7, so it didn't include this fix. We released version 0.8 today (4/8/19), so you should be able to pip install now and have this fix applied.

@thagraybush
Copy link

Thanks! @shinchris I literally added exact same code to my files before coming here, was just going to suggest same change but saw you already fixed it :) So I am good to go and glad getting released to everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.