Improve handling of 500 errors#361
Merged
shinchris merged 1 commit intodevelopmenttableau/server-client-python:developmentfrom Nov 15, 2018
Merged
Improve handling of 500 errors#361shinchris merged 1 commit intodevelopmenttableau/server-client-python:developmentfrom
shinchris merged 1 commit intodevelopmenttableau/server-client-python:developmentfrom
Conversation
graysonarts
approved these changes
Nov 14, 2018
Contributor
graysonarts
left a comment
There was a problem hiding this comment.
Can you create tests for this also? It can be a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #358 to improve how we output 500 errors. Also added error handling for the 2 publishing methods (workbook and datasource) to notify client to use async publishing if synchronous publish call timed out.