Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix #294 & #320#322

Merged
t8y8 merged 1 commit intodevelopmenttableau/server-client-python:developmentfrom
t8y8-fix-320-294tableau/server-client-python:t8y8-fix-320-294Copy head branch name to clipboard
Jul 19, 2018
Merged

Fix #294 & #320#322
t8y8 merged 1 commit intodevelopmenttableau/server-client-python:developmentfrom
t8y8-fix-320-294tableau/server-client-python:t8y8-fix-320-294Copy head branch name to clipboard

Conversation

@t8y8
Copy link
Collaborator

@t8y8 t8y8 commented Jul 19, 2018

We should update tasks to be paginated, but Pager can be more defensive, and should now work against any endpoint

@t8y8 t8y8 requested review from graysonarts and shinchris July 19, 2018 00:48
@t8y8 t8y8 self-assigned this Jul 19, 2018
@t8y8 t8y8 added the bug label Jul 19, 2018
@t8y8
Copy link
Collaborator Author

t8y8 commented Jul 19, 2018

Since I manually tested the repro and fix...

Before:
image

After:
image

@t8y8 t8y8 merged commit 6094eb3 into development Jul 19, 2018
@t8y8 t8y8 deleted the t8y8-fix-320-294 branch July 19, 2018 21:54
@graysonarts graysonarts mentioned this pull request Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.