205 - Pager/Fetcher all the things!#231
Merged
t8y8 merged 10 commits intotableau:developmenttableau/server-client-python:developmentfrom Sep 26, 2017
t8y8:205-feature-pager-all-the-thingst8y8/server-client-python:205-feature-pager-all-the-thingsCopy head branch name to clipboard
Merged
205 - Pager/Fetcher all the things!#231t8y8 merged 10 commits intotableau:developmenttableau/server-client-python:developmentfrom t8y8:205-feature-pager-all-the-thingst8y8/server-client-python:205-feature-pager-all-the-thingsCopy head branch name to clipboard
t8y8 merged 10 commits intotableau:developmenttableau/server-client-python:developmentfrom
t8y8:205-feature-pager-all-the-thingst8y8/server-client-python:205-feature-pager-all-the-thingsCopy head branch name to clipboard
Conversation
graysonarts
reviewed
Sep 25, 2017
| # Get workbooks for user | ||
| @api(version="2.0") | ||
| def populate_workbooks(self, user_item, req_options=None): | ||
| from .. import Pager |
Collaborator
Author
There was a problem hiding this comment.
I did that on the 'users-in-groups' bugfix and just copied the pattern.
Don't think there's a great reason, just how I did it before.
I can move it to a top-level import
Closed
bryceglarsen
pushed a commit
to bryceglarsen/server-client-python
that referenced
this pull request
Dec 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a
checkpointPR for where I'm at in concerting all the models to 'fetch-on-demand' after you callpopulate_XXXon something.Mostly it's a straight forward conversation but a few places have some interesting caveats so posting here for feedback.
EDIT: I've converted all the endpoints, I believe, so they all have on-demand fetching. WOO.
Also added test coverage where there wasn't any. This covers @grbritz's bug as well