From eebaec8485e7a5d8c40414d55a73a757b5628b8e Mon Sep 17 00:00:00 2001 From: Graeme Britz Date: Thu, 9 Mar 2017 17:09:37 -0800 Subject: [PATCH 1/3] ref to dev guide and using dev branch --- contributing.md | 2 +- docs/docs/dev-guide.md | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/contributing.md b/contributing.md index b1eda5b55..0c856c06a 100644 --- a/contributing.md +++ b/contributing.md @@ -48,7 +48,7 @@ anyone can add to an issue: ## Fixes, Implementations, and Documentation For all other things, please submit a PR that includes the fix, documentation, or new code that you are trying to contribute. More information on -creating a PR can be found in the [github documentation](https://help.github.com/articles/creating-a-pull-request/) +creating a PR can be found in the [Development Guide](docs/docs/dev-guide.md) If the feature is complex or has multiple solutions that could be equally appropriate approaches, it would be helpful to file an issue to discuss the design trade-offs of each solution before implementing, to allow us to collectively arrive at the best solution, which most likely exists in the middle diff --git a/docs/docs/dev-guide.md b/docs/docs/dev-guide.md index 8b47609ce..1d85da5a4 100644 --- a/docs/docs/dev-guide.md +++ b/docs/docs/dev-guide.md @@ -22,6 +22,12 @@ This topic describes how to contribute to the Tableau Server Client (Python) pro git clone git@github.com:/server-client-python.git ``` +1. Switch to the development branch + + ```shell + git checkout development + ``` + 1. Run the tests to make sure everything is peachy: ```shell From 78b2d253af366acced930172af312cce321afcfd Mon Sep 17 00:00:00 2001 From: Graeme Britz Date: Wed, 20 Sep 2017 16:51:50 -0700 Subject: [PATCH 2/3] added namespace to call on line 60 --- tableauserverclient/server/endpoint/datasources_endpoint.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tableauserverclient/server/endpoint/datasources_endpoint.py b/tableauserverclient/server/endpoint/datasources_endpoint.py index 1704fd5ac..f8bc60a66 100644 --- a/tableauserverclient/server/endpoint/datasources_endpoint.py +++ b/tableauserverclient/server/endpoint/datasources_endpoint.py @@ -57,7 +57,7 @@ def populate_connections(self, datasource_item): raise MissingRequiredFieldError(error) url = '{0}/{1}/connections'.format(self.baseurl, datasource_item.id) server_response = self.get_request(url) - datasource_item._set_connections(ConnectionItem.from_response(server_response.content)) + datasource_item._set_connections(ConnectionItem.from_response(server_response.content, self.parent_srv.namespace)) logger.info('Populated connections for datasource (ID: {0})'.format(datasource_item.id)) # Delete 1 datasource by id From cae5396bea4b559831dd1c9d031b2d9ee07066c0 Mon Sep 17 00:00:00 2001 From: Graeme Britz Date: Wed, 20 Sep 2017 17:03:15 -0700 Subject: [PATCH 3/3] separated code into 2 lines to pass E501 standards (<120 chars) --- tableauserverclient/server/endpoint/datasources_endpoint.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tableauserverclient/server/endpoint/datasources_endpoint.py b/tableauserverclient/server/endpoint/datasources_endpoint.py index f8bc60a66..b50d5d543 100644 --- a/tableauserverclient/server/endpoint/datasources_endpoint.py +++ b/tableauserverclient/server/endpoint/datasources_endpoint.py @@ -57,7 +57,8 @@ def populate_connections(self, datasource_item): raise MissingRequiredFieldError(error) url = '{0}/{1}/connections'.format(self.baseurl, datasource_item.id) server_response = self.get_request(url) - datasource_item._set_connections(ConnectionItem.from_response(server_response.content, self.parent_srv.namespace)) + datasource_item._set_connections( + ConnectionItem.from_response(server_response.content, self.parent_srv.namespace)) logger.info('Populated connections for datasource (ID: {0})'.format(datasource_item.id)) # Delete 1 datasource by id