226 fix populate connections bug#227
226 fix populate connections bug#227graysonarts merged 6 commits intotableau:developmenttableau/server-client-python:developmentfrom grbritz:226-fix-populate-connections-buggrbritz/server-client-python:226-fix-populate-connections-bugCopy head branch name to clipboard
Conversation
Merge master into development in prep for release
t8y8
left a comment
There was a problem hiding this comment.
🚀
@RussTheAerialist .
Looks like we missed an endpoint :'(
I'll file an item to investigate if any others are out there and how test coverage can catch it.
|
Ok, I just confirmed we have no test coverage on |
|
Can we have a test added as part of this fix? I’ll do an emergency release
as 0.5.1 tomorrow.
…On September 20, 2017 at 5:43:32 PM, Tyler Doyle ***@***.***) wrote:
Ok, I just confirmed we have no test coverage on populate_connections at
all, that's why it didn't get caught.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#227 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFxVW_3Ozksvxk7rlVHXrdI9dDsGA4Yks5skbE0gaJpZM4PeoGw>
.
|
|
@grbritz might not know how to mock it all out. I will see if I can get him the code tonight and he can copy/paste |
|
🚢 okay then I'm going to merge this PR and get a new release out this morning to make sure we don't break too many people. @t8y8 are the tests something you could work on? I have some other bugs on my plate right now that need to take priority for various reasons. |
|
@RussTheAerialist Thanks for merging. I'll see if I can figure out how to add the mocks but I have other more urgent tasks I need to get to today. FYI if you didn't know, my PR was into the development branch, so users of the master branch will still be experiencing the issue. |
|
@RussTheAerialist yeah I'll work on it -- I need those tests for 'pager all the things' anyway! |
Minor doc improvements
This address issue #226