call the detect in the auth endpoint in case we aren't detecting#220
Merged
graysonarts merged 1 commit intodevelopmenttableau/server-client-python:developmentfrom Sep 15, 2017
auth-endpoint-does-not-detect-namespacestableau/server-client-python:auth-endpoint-does-not-detect-namespacesCopy head branch name to clipboard
Merged
call the detect in the auth endpoint in case we aren't detecting#220graysonarts merged 1 commit intodevelopmenttableau/server-client-python:developmentfrom auth-endpoint-does-not-detect-namespacestableau/server-client-python:auth-endpoint-does-not-detect-namespacesCopy head branch name to clipboard
graysonarts merged 1 commit intodevelopmenttableau/server-client-python:developmentfrom
auth-endpoint-does-not-detect-namespacestableau/server-client-python:auth-endpoint-does-not-detect-namespacesCopy head branch name to clipboard
Conversation
…ing the server version
t8y8
approved these changes
Sep 15, 2017
Collaborator
t8y8
left a comment
There was a problem hiding this comment.
🚀
To use Server you have to sign_in, so this should catch anyone who doesn't detect version :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The auth flow doesn't use the _make_requests call in the base object. Accidentally pushed to upstream rather than my own fork.