Add revision settings to Update Site#187
Merged
t8y8 merged 4 commits intotableau:developmenttableau/server-client-python:developmentfrom May 10, 2017
t8y8:186-feature-revision-settingst8y8/server-client-python:186-feature-revision-settingsCopy head branch name to clipboard
Merged
Add revision settings to Update Site#187t8y8 merged 4 commits intotableau:developmenttableau/server-client-python:developmentfrom t8y8:186-feature-revision-settingst8y8/server-client-python:186-feature-revision-settingsCopy head branch name to clipboard
t8y8 merged 4 commits intotableau:developmenttableau/server-client-python:developmentfrom
t8y8:186-feature-revision-settingst8y8/server-client-python:186-feature-revision-settingsCopy head branch name to clipboard
Conversation
Contributor
|
How come you didn't added a getter / setter for revisionLimit? How come these values are not read from get requests? I haven't checked the code to see if we are returning them but it seems like we would be. |
Collaborator
Author
|
I didn't change the model, it was already there so I didn't even check, I just added it to the serializer |
Contributor
|
Huh. Not good that we have a partial implementation like that. Oh well. Thanks for fixing! For your CL, though, it looks like we are simply naming the member "revision_limit" and not using a getter / setter. This doesn't match any of our other properties. Can you fix that? We might also debate on requiring revision_history_enabled to be true to set it but for now, I don't think that matters. Besides that it looks great. |
t8y8
added a commit
to t8y8/server-client-python
that referenced
this pull request
Jun 28, 2017
Revision History settings were present in the SiteItem model but not actually serialized and didn't have setters/getters. I've updated that and enhanced the is_int decorator to allow exemptions in the case of sentinels that fall outside the normal range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #186
(And helps me with some internal stuff)
Updated tests and manually tested internally