Feature 99 add flag to use server version#168
Merged
graysonarts merged 3 commits intotableau:developmenttableau/server-client-python:developmentfrom Apr 11, 2017
graysonarts:feature-99-add-flag-to-use-server-versionCopy head branch name to clipboard
Merged
Feature 99 add flag to use server version#168graysonarts merged 3 commits intotableau:developmenttableau/server-client-python:developmentfrom graysonarts:feature-99-add-flag-to-use-server-versionCopy head branch name to clipboard
graysonarts merged 3 commits intotableau:developmenttableau/server-client-python:developmentfrom
graysonarts:feature-99-add-flag-to-use-server-versionCopy head branch name to clipboard
Conversation
t8y8
approved these changes
Apr 10, 2017
Collaborator
t8y8
left a comment
There was a problem hiding this comment.
A minor thing but....
🚀 🚀 🚀
🎉
tableauserverclient/server/server.py
Outdated
| self.server_info = ServerInfo(self) | ||
|
|
||
| if use_server_version: | ||
| self.use_highest_version() |
Collaborator
There was a problem hiding this comment.
This will throw the warning every time someone uses the flag since this is the legacy endpoint.
I think you want this to be self.use_server_version() too :)
Collaborator
|
🚀 |
t8y8
pushed a commit
to t8y8/server-client-python
that referenced
this pull request
Jun 28, 2017
* Added a flag to the server object to allow you go use the server version by default * I disliked the 'highest version' I think server version makes more sense. * ctor should use the non-dep function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make @t8y8 happy.