Fix for 162#163
Merged
t8y8 merged 1 commit intotableau:developmenttableau/server-client-python:developmentfrom Apr 10, 2017
Merged
Fix for 162#163t8y8 merged 1 commit intotableau:developmenttableau/server-client-python:developmentfrom
t8y8 merged 1 commit intotableau:developmenttableau/server-client-python:developmentfrom
Conversation
Contributor
|
Works for me! Thanks for the quick turnaround. 👍 |
t8y8
added a commit
to t8y8/server-client-python
that referenced
this pull request
Jun 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #162
I also did a search and the only remaining
set()calls are tags or filters, places where we actually do use tags.Note that this could go away once we decide on the final pattern for internal paging (like maybe we stop keeping models in sync with the Server), but this is a minimal fix that doesn't change the world in the mean time.
/cc @tagyoureit (can you try with this patch and see if it resolves your issue)