Fixing set default permissions for virtual connections#1535
Merged
jacalata merged 2 commits intotableau:developmenttableau/server-client-python:developmentfrom Dec 13, 2024
TrimPeachu:vc_perms_bugfixTrimPeachu/server-client-python:vc_perms_bugfixCopy head branch name to clipboard
Merged
Fixing set default permissions for virtual connections#1535jacalata merged 2 commits intotableau:developmenttableau/server-client-python:developmentfrom TrimPeachu:vc_perms_bugfixTrimPeachu/server-client-python:vc_perms_bugfixCopy head branch name to clipboard
jacalata merged 2 commits intotableau:developmenttableau/server-client-python:developmentfrom
TrimPeachu:vc_perms_bugfixTrimPeachu/server-client-python:vc_perms_bugfixCopy head branch name to clipboard
Conversation
Contributor
|
Can you also add a unit test to ensure that the attribute is set correctly and able to be read? |
Contributor
Author
|
@jorwoods tests added |
jacalata
approved these changes
Dec 13, 2024
Contributor
jacalata
left a comment
There was a problem hiding this comment.
Looks good afaict, although I'm not actually familiar with the feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1525