Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Site can now be queried by name#151

Closed
VathsalaAchar wants to merge 5 commits intotableau:developmenttableau/server-client-python:developmentfrom
AtheonAnalytics:developAtheonAnalytics/server-client-python:developCopy head branch name to clipboard
Closed

Site can now be queried by name#151
VathsalaAchar wants to merge 5 commits intotableau:developmenttableau/server-client-python:developmentfrom
AtheonAnalytics:developAtheonAnalytics/server-client-python:developCopy head branch name to clipboard

Conversation

@VathsalaAchar
Copy link
Contributor

This is a Nice To Have for our end. We prefer to work with names rather than ids.

@t8y8
Copy link
Collaborator

t8y8 commented Feb 28, 2017

@VathsalaAchar thank you for the PR!

I've tagged it as an 'enhancement' and we will take a look.

I need to confirm that we want to do this via the legacy endpoint (the key=name) method, and not be leveraging native filtering, or something like that.

In the mean time, please fill out the CLA, as documented here: http://tableau.github.io/contributing.html

Thanks!

EDIT: Please rebase this PR against 'Development'

/cc @LGraber @RussTheAerialist

@VathsalaAchar VathsalaAchar changed the base branch from master to development March 1, 2017 08:47
@VathsalaAchar
Copy link
Contributor Author

@t8y8 thank you for the input. We sent in the CLA yesterday and I got a confirmation that it was filed for your records. I have also rebased the PR as asked.

@t8y8
Copy link
Collaborator

t8y8 commented Mar 1, 2017

@VathsalaAchar it looked like you added in some work from the 'inprogress' branch.

That branch is pretty old, and the permissions changes aren't relevant to your original PR (nor are they necessarily the design we want to go with) -- was that intentional?

It looks like your changes are made against a master base though the PR is submitted against development. This has the side effect of missing a largeish change where all endpoints take an annotation that specifies the versions it's compatible with.

Can you stash just your changes on and push them to a new branch made from development? That should clear up any possible merge conflicts :)

@t8y8
Copy link
Collaborator

t8y8 commented Mar 1, 2017

This is related to #49

@VathsalaAchar
Copy link
Contributor Author

@t8y8 No that wasn't intentional, I'll fix the in progress and the master branch mess. Apologies for that!

@VathsalaAchar
Copy link
Contributor Author

I have made a PR in #153 so I'll close this now. Thank you for all your help @t8y8 .

@VathsalaAchar VathsalaAchar deleted the develop branch March 2, 2017 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.