Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

docs: add docstrings detailing the filter options#1435

Merged
jacalata merged 2 commits intotableau:developmenttableau/server-client-python:developmentfrom
jorwoods:jorwoods/filter_docstringsjorwoods/server-client-python:jorwoods/filter_docstringsCopy head branch name to clipboard
Aug 22, 2024
Merged

docs: add docstrings detailing the filter options#1435
jacalata merged 2 commits intotableau:developmenttableau/server-client-python:developmentfrom
jorwoods:jorwoods/filter_docstringsjorwoods/server-client-python:jorwoods/filter_docstringsCopy head branch name to clipboard

Conversation

@jorwoods
Copy link
Contributor

@jorwoods jorwoods commented Aug 6, 2024

Add docstrings to QuerySetEndpoint subclasses so that details on what filter options are available can be displayed within the editor rather than navigating to the docs separately.

Copy link
Contributor

@bcantoni bcantoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @jacalata could you also please review this one?

Copy link
Contributor

@jacalata jacalata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should figure out a way to just publish the list of filters with each version.

@jacalata jacalata merged commit a3028d7 into tableau:development Aug 22, 2024
@jorwoods jorwoods deleted the jorwoods/filter_docstrings branch August 22, 2024 20:19
@jorwoods
Copy link
Contributor Author

Yeah, the way I compiled this list was by scraping the filtering and sorting docs. May be difficult to update it with every server version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.