chore: type hint QuerySet and QuerySetEndpoint#1399
Merged
jacalata merged 8 commits intotableau:developmenttableau/server-client-python:developmentfrom Jun 19, 2024
jorwoods:jorwoods/queryset_typingjorwoods/server-client-python:jorwoods/queryset_typingCopy head branch name to clipboard
Merged
chore: type hint QuerySet and QuerySetEndpoint#1399jacalata merged 8 commits intotableau:developmenttableau/server-client-python:developmentfrom jorwoods:jorwoods/queryset_typingjorwoods/server-client-python:jorwoods/queryset_typingCopy head branch name to clipboard
jacalata merged 8 commits intotableau:developmenttableau/server-client-python:developmentfrom
jorwoods:jorwoods/queryset_typingjorwoods/server-client-python:jorwoods/queryset_typingCopy head branch name to clipboard
Conversation
There are many methods on QuerySet that implicitly call fetch_all. This moves emptying the result cache to immediately before the explicit call to fetch_call after the page number has been updated. This ensures that the correct latest page is fetched.
jacalata
approved these changes
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes heavier use of the generics and TypeVars like what is defined in PEP 484, so that usage of
.alland.filterpreserve type information of objects coming from the subclass's endpoints.This also adds a
with_page_sizemethod onto theQuerySetobject so that users can set the page request size in the same builder pattern chain.