chore: add typing to Pager#1390
Merged
jacalata merged 3 commits intotableau:developmenttableau/server-client-python:developmentfrom Jun 21, 2024
jorwoods:jorwoods/typed_pagerjorwoods/server-client-python:jorwoods/typed_pagerCopy head branch name to clipboard
Merged
chore: add typing to Pager#1390jacalata merged 3 commits intotableau:developmenttableau/server-client-python:developmentfrom jorwoods:jorwoods/typed_pagerjorwoods/server-client-python:jorwoods/typed_pagerCopy head branch name to clipboard
jacalata merged 3 commits intotableau:developmenttableau/server-client-python:developmentfrom
jorwoods:jorwoods/typed_pagerjorwoods/server-client-python:jorwoods/typed_pagerCopy head branch name to clipboard
Conversation
e1d4441 to
6e68d8b
Compare
jacalata
reviewed
Jun 20, 2024
jacalata
approved these changes
Jun 20, 2024
jacalata
approved these changes
Jun 21, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add typing to the
Pagerobject. The typing addition makes it clearer for language servers to detect what type of objects are yielded from the iterable, making TSC easier to use.Additionally, this simplifies the way items are returned from the intermediate list object. Different from before, if the server count changes while the Pager is working, this change will continue to function. If desired, it can be reset to exiting gracefully should the server count change.