feat: allow viz height and width parameters#1348
Merged
jacalata merged 4 commits intotableau:developmenttableau/server-client-python:developmentfrom Jan 26, 2024
jorwoods:jorwoods/pdf_height_widthjorwoods/server-client-python:jorwoods/pdf_height_widthCopy head branch name to clipboard
Merged
feat: allow viz height and width parameters#1348jacalata merged 4 commits intotableau:developmenttableau/server-client-python:developmentfrom jorwoods:jorwoods/pdf_height_widthjorwoods/server-client-python:jorwoods/pdf_height_widthCopy head branch name to clipboard
jacalata merged 4 commits intotableau:developmenttableau/server-client-python:developmentfrom
jorwoods:jorwoods/pdf_height_widthjorwoods/server-client-python:jorwoods/pdf_height_widthCopy head branch name to clipboard
Conversation
jacalata
approved these changes
Jan 24, 2024
| if self.max_age != -1: | ||
| params["maxAge"] = self.max_age | ||
|
|
||
| if (self.viz_height is None) ^ (self.viz_width is None): |
Contributor
There was a problem hiding this comment.
I think this operator is unusual enough that a comment would be helpful
Contributor
Author
|
Resolves #1324 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support to PDFRequestOptions for viz height and width.