Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

CGI Removal#1346

Merged
jacalata merged 5 commits intotableau:developmenttableau/server-client-python:developmentfrom
securehst:mastersecurehst/server-client-python:masterCopy head branch name to clipboard
Jan 22, 2024
Merged

CGI Removal#1346
jacalata merged 5 commits intotableau:developmenttableau/server-client-python:developmentfrom
securehst:mastersecurehst/server-client-python:masterCopy head branch name to clipboard

Conversation

@securehst
Copy link
Contributor

Removed cgi due to deprecation and updated to use email.message.Message instead.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @markm-io to sign the Salesforce Inc. Contributor License Agreement.

@bcantoni
Copy link
Contributor

@markm-io thanks for putting this together. There are 2 other places the CGI module is used. Would you mind updating flows_endpoint.py and workbooks_endpoint.py here as well?

Also, you'll need to fix those black and mypy errors before this PR will go green. You can see the steps explained more in the dev guide.

@securehst
Copy link
Contributor Author

@markm-io thanks for putting this together. There are 2 other places the CGI module is used. Would you mind updating flows_endpoint.py and workbooks_endpoint.py here as well?

Also, you'll need to fix those black and mypy errors before this PR will go green. You can see the steps explained more in the dev guide.

All files have been updates and both black and mypy commands have been run with corrections made.

@jacalata jacalata merged commit 969922b into tableau:development Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.