101 unit test coverage sort.py by talvalin · Pull Request #130 · tableau/server-client-python

talvalin · Jan 16, 2017

First attempt at tests for sort.py. I commented out my test for test_filter_combo, since it would intermittently fail because of the ordering of the two filters, so any advice on how to handle this particular issue (or to just bin the test) would be appreciated.

Release 0.3

talvalin · Jan 16, 2017

Two questions whilst I'm here:

Should I have forked development instead of master?
Are my settings for origin and upstream actually correct (https://gyazo.com/ce45182c1c65ec87fb9e5005f0e865f6)

t8y8 · Jan 16, 2017

Always always always fork development.

Pretend master doesn't exist :)

t8y8

🚀

Can you publish the updated stats? I can't check as easily while on the road.

t8y8 · Jan 19, 2017

test/test_sort.py

+
+            self.assertEqual(resp.request.query, 'pagenumber=13&pagesize=13&sort=name:asc')
+
+    # def test_filter_combo(self):


This is because of the determinism problem, right?

After @RussTheAerialist does his bit uncomment and rebase on top of his changes and this should be good to go.

talvalin · Jan 22, 2017

Updated my PR as requested, but I have no idea how to publish the updated stats. Or indeed how to update the stats.

talvalin · Jan 23, 2017

Okay, so not sure if we should be discussing here or in the deterministic order PR, but my test_filter_combo test passed for 2.7, 3.3, 3.4 and 3.5, but failed for 3.6. Any ideas?

t8y8 · Jan 23, 2017

Yes, the results aren't deterministic! You'll get results that vary from run to run in python 3, until his changes are checked in :)

graysonarts · Jan 23, 2017

Okay I've merged #131 Sorry for the delay! You'll want to rebase and repush to pick up the squashed change

…alvalin/server-client-python into 101-unit-test-coverage-sort.py

talvalin · Jan 23, 2017

No problem. Sorry for being dim about the fact that tests were going to fail until the merge. All good now though now I hope.

talvalin · Jan 25, 2017

Updated stats:

Name                                                          Stmts   Miss  Cover
---------------------------------------------------------------------------------
tableauserverclient\__init__.py                                   5      0   100%
tableauserverclient\datetime_helpers.py                          18      2    89%
tableauserverclient\models\__init__.py                           15      0   100%
tableauserverclient\models\connection_credentials.py             17      8    53%
tableauserverclient\models\connection_item.py                    38      0   100%
tableauserverclient\models\datasource_item.py                   105      5    95%
tableauserverclient\models\exceptions.py                          2      0   100%
tableauserverclient\models\fileupload_item.py                    17     10    41%
tableauserverclient\models\group_item.py                         39      0   100%
tableauserverclient\models\interval_item.py                     112      9    92%
tableauserverclient\models\pagination_item.py                    22      0   100%
tableauserverclient\models\project_item.py                       59      1    98%
tableauserverclient\models\property_decorators.py                78     14    82%
tableauserverclient\models\schedule_item.py                     146      5    97%
tableauserverclient\models\server_info_item.py                   21      0   100%
tableauserverclient\models\site_item.py                         147     14    90%
tableauserverclient\models\tableau_auth.py                       18      9    50%
tableauserverclient\models\tag_item.py                           13      0   100%
tableauserverclient\models\user_item.py                         112      4    96%
tableauserverclient\models\view_item.py                          56      6    89%
tableauserverclient\models\workbook_item.py                     147      8    95%
tableauserverclient\namespace.py                                  1      0   100%
tableauserverclient\server\__init__.py                            9      0   100%
tableauserverclient\server\endpoint\__init__.py                  12      0   100%
tableauserverclient\server\endpoint\auth_endpoint.py             34      3    91%
tableauserverclient\server\endpoint\datasources_endpoint.py     102     22    78%
tableauserverclient\server\endpoint\endpoint.py                  56     10    82%
tableauserverclient\server\endpoint\exceptions.py                20      0   100%
tableauserverclient\server\endpoint\fileuploads_endpoint.py      46     31    33%
tableauserverclient\server\endpoint\groups_endpoint.py           78      4    95%
tableauserverclient\server\endpoint\projects_endpoint.py         40      0   100%
tableauserverclient\server\endpoint\schedules_endpoint.py        46      8    83%
tableauserverclient\server\endpoint\server_info_endpoint.py      16      0   100%
tableauserverclient\server\endpoint\sites_endpoint.py            59      4    93%
tableauserverclient\server\endpoint\users_endpoint.py            60      1    98%
tableauserverclient\server\endpoint\views_endpoint.py            23      0   100%
tableauserverclient\server\endpoint\workbooks_endpoint.py       139     13    91%
tableauserverclient\server\exceptions.py                          2      0   100%
tableauserverclient\server\filter.py                             19      1    95%
tableauserverclient\server\pager.py                              25      2    92%
tableauserverclient\server\request_factory.py                   278     46    83%
tableauserverclient\server\request_options.py                    41      0   100%
tableauserverclient\server\server.py                             83      6    93%
tableauserverclient\server\sort.py                                6      0   100%
---------------------------------------------------------------------------------
TOTAL                                                          2382    246    90%

t8y8 · Jan 25, 2017

🚀

Brings sort.py coverage up to 100% * Adding test_sort.py with initial tests * Updated based on pycodestyle tests

jdomingu and others added 3 commits December 22, 2016 16:19

Add analytics script

05974c3

Merge pull request tableau#128 from tableau/development

8e6c907

Release 0.3

Adding test_sort.py with initial tests

12a96f0

Updated based on pycodestyle tests[F

2bee69b

t8y8 approved these changes Jan 19, 2017

View reviewed changes

Updated based on PR#131

afc41e9

jdomingu and others added 5 commits January 24, 2017 02:44

Add analytics script

20868af

Adding test_sort.py with initial tests

873fe44

Updated based on pycodestyle tests[F

7717120

Updated based on PR#131

1d51301

Merge branch '101-unit-test-coverage-sort.py' of https://github.com/T…

7b32904

…alvalin/server-client-python into 101-unit-test-coverage-sort.py

t8y8 merged commit 4700dda into tableau:development Jan 25, 2017

talvalin deleted the 101-unit-test-coverage-sort.py branch February 16, 2017 03:14

graysonarts pushed a commit that referenced this pull request Mar 23, 2017

101 unit test coverage sort.py (#130)

2d3e279

Brings sort.py coverage up to 100% * Adding test_sort.py with initial tests * Updated based on pycodestyle tests

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

101 unit test coverage sort.py#130

101 unit test coverage sort.py#130
t8y8 merged 10 commits intotableau:developmenttableau/server-client-python:developmentfrom
talvalin:101-unit-test-coverage-sort.pytalvalin/server-client-python:101-unit-test-coverage-sort.pyCopy head branch name to clipboard

talvalin commented Jan 16, 2017

Uh oh!

talvalin commented Jan 16, 2017

Uh oh!

t8y8 commented Jan 16, 2017

Uh oh!

t8y8 left a comment

Uh oh!

t8y8 Jan 19, 2017

Uh oh!

talvalin commented Jan 22, 2017 •

edited

Loading

Uh oh!

talvalin commented Jan 23, 2017

Uh oh!

t8y8 commented Jan 23, 2017

Uh oh!

graysonarts commented Jan 23, 2017

Uh oh!

talvalin commented Jan 23, 2017

Uh oh!

talvalin commented Jan 25, 2017

Uh oh!

t8y8 commented Jan 25, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		self.assertEqual(resp.request.query, 'pagenumber=13&pagesize=13&sort=name:asc')

		# def test_filter_combo(self):

Search code, repositories, users, issues, pull requests...

Conversation

talvalin commented Jan 16, 2017

Uh oh!

talvalin commented Jan 16, 2017

Uh oh!

t8y8 commented Jan 16, 2017

Uh oh!

t8y8 left a comment

Choose a reason for hiding this comment

Uh oh!

t8y8 Jan 19, 2017

Choose a reason for hiding this comment

Uh oh!

talvalin commented Jan 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

talvalin commented Jan 23, 2017

Uh oh!

t8y8 commented Jan 23, 2017

Uh oh!

graysonarts commented Jan 23, 2017

Uh oh!

talvalin commented Jan 23, 2017

Uh oh!

talvalin commented Jan 25, 2017

Uh oh!

t8y8 commented Jan 25, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

talvalin commented Jan 22, 2017 •

edited

Loading