fix behavior when url has no protocol#1125
Merged
jacalata merged 2 commits intodevelopmenttableau/server-client-python:developmentfrom Oct 6, 2022
jac/url-recognitiontableau/server-client-python:jac/url-recognitionCopy head branch name to clipboard
Merged
fix behavior when url has no protocol#1125jacalata merged 2 commits intodevelopmenttableau/server-client-python:developmentfrom jac/url-recognitiontableau/server-client-python:jac/url-recognitionCopy head branch name to clipboard
jacalata merged 2 commits intodevelopmenttableau/server-client-python:developmentfrom
jac/url-recognitiontableau/server-client-python:jac/url-recognitionCopy head branch name to clipboard
Conversation
anyoung-tableau
approved these changes
Sep 27, 2022
t8y8
suggested changes
Sep 30, 2022
t8y8
approved these changes
Oct 5, 2022
8eebdfa to
7f47473
Compare
jacalata
added a commit
that referenced
this pull request
Oct 11, 2022
* Allow injection of session_factory to allow use of a custom session * Jac/show server info (#1118) * Fix bug in exposing ExcelRequestOptions and test (#1123) * Fix a few pylint errors (#1124) * fix behavior when url has no protocol (#1125) * smoke test for pypi * Add permission control for Data Roles and Metrics (Issue #1063) (#1120) Co-authored-by: Marwan Baghdad <mrwanbaghdad76@gmail.com> Co-authored-by: jorwoods <jorwoods@users.noreply.github.com> Co-authored-by: Brian Cantoni <bcantoni@salesforce.com> Co-authored-by: TrimPeachu <77048868+TrimPeachu@users.noreply.github.com>
jacalata
added a commit
that referenced
this pull request
Feb 14, 2023
* Allow injection of sessions (#1111) * show server info (#1118) * Fix bug in exposing ExcelRequestOptions and test (#1123) * Fix a few pylint errors (#1124) * fix behavior when url has no protocol (#1125) * Add permission control for Data Roles and Metrics (Issue #1063) (#1120) * add option to pass specific datasources (#1150) * allow user agent to be set by caller (#1166) * Fix issues with connections publishing workbooks (#1171) * Allow download to file-like objects (#1172) * Add updated_at to JobItem class (#1182) * fix revision references where xml returned does not match docs (#1176) * Do not create empty connections list (#1178) --------- Co-authored-by: Marwan Baghdad <mrwanbaghdad76@gmail.com> Co-authored-by: jorwoods <jorwoods@users.noreply.github.com> Co-authored-by: Brian Cantoni <bcantoni@salesforce.com> Co-authored-by: TrimPeachu <77048868+TrimPeachu@users.noreply.github.com> Co-authored-by: Stu Tomlinson <stu@nosnilmot.com> Co-authored-by: Jeremy Harris <jercharris89@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defaulting to http if no protocol is entered, since that is the behavior we expect in tabcmd currently.
Manually handle a redirect on login, so we don't send a GET request that fails.