Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

"from_response" should not be on TableauAuth object #1

Copy link
Copy link
@LGraber

Description

@LGraber
Issue body actions

You must have missed this from an earlier review. "from_response" implies that it is constructing the class object. This code is simply parsing the response of "signin" and is not constructing a TableauAuth object. Please just move this to the "signin" method.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.