Large PR -- Adding Tests, fixing a few bugs that revealed, and cleaning up small nits#2

Merged

benlower merged 7 commits intotableau:masterfrom

t8y8:master

May 12, 2016

Commits on May 10, 2016

PEP8-ify some files so future editors will be happy. Also add a test file and add some test cases for a help method I plan to update in the next commit. I made _is_valid_file a static method since …
Show description for 2c605e5
t8y8
committed
2c605e5
Copy full SHA for 2c605e5
Refactor _is_valid_file to be mroe pythonic and extensible if we add more filetypes in the future. No more C++ code in the python :)
t8y8
committed
0f5f757
Copy full SHA for 0f5f757

Commits on May 11, 2016

Added new test cases
t8y8
committed
c5e53ec
Copy full SHA for c5e53ec
Update Replicate Workbook example to using DictReader which makes the code more readable. Also remove the unnecessary copy.copy call and import. Small refactor of parameter name for Workbook.save_a…
Show description for a36337f
t8y8
committed
a36337f
Copy full SHA for a36337f
Added tests to cover basic cases for Workbook, Datasource, and Connection classes. The temp-file setUp isn't the greatest but it's functional for now and will help with confidance if we decide to m…
Show description for d3cb1be
t8y8
committed
d3cb1be
Copy full SHA for d3cb1be
One more test
t8y8
committed
564c172
Copy full SHA for 564c172
Updating tests to work on Windows and Mac, Py2 and Py3. I'm manually managing temp files right now, but we may want to modify our Workbook and Datasource classes to accept all File-Like objects in …
Show description for cc94371
t8y8
committed
cc94371
Copy full SHA for cc94371