#141 Enable Zip64 Extensions To Support Zipfile >= 2GB#143
Closed
doulam wants to merge 8 commits intotableau:developmenttableau/document-api-python:developmentfrom
Closed
#141 Enable Zip64 Extensions To Support Zipfile >= 2GB#143doulam wants to merge 8 commits intotableau:developmenttableau/document-api-python:developmentfrom
doulam wants to merge 8 commits intotableau:developmenttableau/document-api-python:developmentfrom
Conversation
Release 0.5
* Fix tableau#117 by only attempting files with the right extension inside the archive (tableau#118) * Commenting and Docstring cleanup. A few very small code cleanups (tableau#120) Add docstrings and remove clutter. I also made some very tiny tweaks to some code for clarity. * Small cleanups for various editors. Play nice with built in test-runners (tableau#121) * Add Py36, update travis to use pycodestyle (tableau#124) * Add `initial sql` and `query band` support (tableau#123) Addresses tableau#109 and tableau#110 * Prep for release of 0.6 (tableau#125) * Prep for release of 0.6 * wordsmithing the changelog
Contributor
|
Hello! Thanks for the contribution. A few things we need to take care of:
I did a quick google, and this was enabled by default in python 3.4, but since we support 2.7, I think it's a simple enough change to make. |
Contributor
Author
|
@t8y8 Sure, let me rebase this on the development branch. Do you have quick instructions on how to sign github CLA? Never done this before. Thanks. |
Contributor
Author
|
@t8y8 nvm. I found the Tableau CLA on the Tableau Github. Will attach it on my update. Thanks. |
Contributor
Author
|
Close this PR. Going to resubmit a new one from the development branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I enabled the option AllowZip64=True for ZipFile() in the xfiles.py. This allows documentapi to handle tdsx/twbx that is greater than 2GB.