[WIP] Corrections and Todos #325
Conversation
| @@ -1018,7 +1018,7 @@ container configuration: | ||
|
|
||
| <tag | ||
| name="sonata.admin" | ||
| manager-type="doctrine_phpcr" | ||
| manager_type="doctrine_phpcr" |
There was a problem hiding this comment.
@wouterj I guess the Sonata XML needs fixing - this works but the - does not.
There was a problem hiding this comment.
this has nothing to do with Sonata XML. It's something which is wrong in the Symfony code while parsing the arguments for tags. I've submitted a fix for it: symfony/symfony#9489
There was a problem hiding this comment.
wow, nobody ever did tags with hyphens? or they did not care to even report the problem? well, thanks for finding this.
@dantleech: i think this would merit an xml comment after the to explain the oddity, saying that the hyphen would work from symfony 2.4 on. even if it gets fixed now, it won't be fixed for already released 2.3 versions
|
All updated. |
|
apart from that, agree with the corrections. just merge along if you want. |
|
sorry, i merged another PR that fixed the doctrine command. can you please merge master into your branch and fix the conflict? otherwise i propose to add the note about xml tag names with underscores and then merge. |
Bugs in the tutorial
|
Merged! I added a note about the |
|
fine for me. thanks! |
Did a test run of the full Creating CMS with Routing Auto tutorial, this PR will eventually fix all the bugs encountered.