Allow to define the IP on which server:start should listen to
#525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to the flags, one can also uses the SYMFONY_LISTEN_IP and SYMFONY_ALL_IP environment variables
|
Looks good to me, thank you @tucksaun |
|
Working great, thanks for the quick update. |
|
hi @tucksaun , thanks for this PR. i have a question, is there a way to set this config as default? so I don't need to add |
No config files to do this at the moment. But you can add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two additional flags to the
server:startcommand:listen-ipallows to define precisely the IP one wants to use and defaults to “127.0.0.1”, andallow-all-ipallows to enable listening on all interfaces (the behavior before #494 gets merged).In addition to the flags, one can also use the SYMFONY_LISTEN_IP and SYMFONY_ALL_IP environment variables.
I didn’t go the “listen address” path because it would break the port flag and the preferred port logic but can move towards this later one with some BC layer.
Refs #494
Fix #523, fix #524