Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Expose the CLI version in the WDT #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

tucksaun
Copy link
Member

@tucksaun tucksaun commented Nov 2, 2023

fix #365

Screenshot 2023-11-02 at 17 29 39

while working on this I noticed the icon in the WDT was not optimal on small screens so I took the opportunity to fix classes to make it displayed as expected:
Screenshot 2023-11-02 at 17 29 20

@tucksaun tucksaun requested a review from fabpot November 2, 2023 16:36
@tucksaun
Copy link
Member Author

tucksaun commented Nov 2, 2023

@javiereguiluz can you confirm the class fix is the right one?

@stof
Copy link

stof commented Nov 2, 2023

@tucksaun you should put the fix #365 in the PR description rather than the PR title as cross-references don't work in the title.

@tucksaun tucksaun changed the title Expose the CLI version in the WDT, fix #365 Expose the CLI version in the WDT Nov 2, 2023
@tucksaun
Copy link
Member Author

tucksaun commented Nov 2, 2023

@tucksaun you should put the fix #365 in the PR description rather than the PR title as cross-references don't work in the title.

done

local/php/toolbar.go Outdated Show resolved Hide resolved
local/php/toolbar.go Outdated Show resolved Hide resolved
@tucksaun tucksaun force-pushed the feat/wdt-cli-version branch from 14dd84b to 29259e3 Compare November 2, 2023 19:30
@tucksaun tucksaun force-pushed the feat/wdt-cli-version branch from 29259e3 to 2e5951f Compare November 2, 2023 19:31
local/php/toolbar.go Outdated Show resolved Hide resolved
Co-authored-by: Fabien Potencier <fabien@potencier.org>
@fabpot fabpot merged commit 8dd5d02 into symfony-cli:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Display the CLI version in the inject web debug toolbar item
3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.