This repository was archived by the owner on Nov 27, 2020. It is now read-only.
Remove templating layer from standard edition #1110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Sep 13, 2017
ogizanagi
approved these changes
Sep 13, 2017
javiereguiluz
approved these changes
Sep 14, 2017
Tobion
added a commit
that referenced
this pull request
Oct 1, 2017
This PR was merged into the 3.4 branch. Discussion ---------- Remove templating layer from standard edition Also works without it as `\Symfony\Bundle\FrameworkBundle\Controller\ControllerTrait::render` will just use twig directly then. Whether we deprecate or not deprecate the templating layer (symfony/symfony#21036) we should still promote not to use it by default. Commits ------- c243457 Remove templating layer from standard edition
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also works without it as
\Symfony\Bundle\FrameworkBundle\Controller\ControllerTrait::renderwill just use twig directly then. Whether we deprecate or not deprecate the templating layer (symfony/symfony#21036) we should still promote not to use it by default.