This repository was archived by the owner on Nov 27, 2020. It is now read-only.
app.php and console: no need to declare $loader variable #1074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The var isn't being used anywhere in the file(s). Because of how "require" works, $loader is still a global variable.
|
👍 Should be merged in 2.7 since #964 is also in 2.7 that removed the $loader usage. |
|
@Tobion I'm gonna split it into two PRs, as EDIT: …or not. I don't know how to split it :/ |
|
Good catch, thanks @MacDada. |
fabpot
added a commit
that referenced
this pull request
Jun 16, 2017
…(MacDada) This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #1074). Discussion ---------- app.php and console: no need to declare $loader variable The var isn't being used anywhere in the file(s). Because of how "require" works, $loader is still a global variable. Commits ------- 66f5804 app.php and console: no need to declare $loader variable
Tobion
added a commit
that referenced
this pull request
Jun 16, 2017
#1074 for app_dev.php which has been forgotten when rebasing
fabpot
added a commit
that referenced
this pull request
Jun 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The var isn't being used anywhere in the file(s).
Because of how "require" works,
$loader is still a global variable.