Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Nov 14, 2019. It is now read-only.

#266 Self update is not detecting the installed version #269

Merged
merged 1 commit into from
Jul 22, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions 4 src/Symfony/Installer/DownloadCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,12 @@ abstract class DownloadCommand extends Command
/**
* @var string The latest installer version
*/
private $latestInstallerVersion;
protected $latestInstallerVersion;

/**
* @var string The version of the local installer being executed
*/
private $localInstallerVersion;
protected $localInstallerVersion;

/**
* @var string The path to the downloaded file
Expand Down
11 changes: 1 addition & 10 deletions 11 src/Symfony/Installer/SelfUpdateCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Filesystem\Filesystem;
use Symfony\Component\Filesystem\Exception\IOException;

/**
Expand All @@ -33,11 +32,6 @@ class SelfUpdateCommand extends DownloadCommand
*/
private $tempDir;

/**
* @var string The latest installer version
*/
private $latestInstallerVersion;

/**
* @var string The URL where the latest installer version can be downloaded
*/
Expand Down Expand Up @@ -92,10 +86,7 @@ public function isEnabled()
*/
protected function initialize(InputInterface $input, OutputInterface $output)
{
$this->fs = new Filesystem();
$this->output = $output;

$this->latestInstallerVersion = $this->getUrlContents(Application::VERSIONS_URL);
parent::initialize($input, $output);
$this->remoteInstallerFile = 'http://symfony.com/installer';
$this->currentInstallerFile = realpath($_SERVER['argv'][0]) ?: $_SERVER['argv'][0];
$this->tempDir = sys_get_temp_dir();
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.