This repository was archived by the owner on Nov 14, 2019. It is now read-only.
Intercept and customize error from Guzzle #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ef89ad to
ef91ce2
Compare
| $handler = Utils::getDefaultHandler(); | ||
| } catch (\RuntimeException $e) { | ||
| throw new \RuntimeException( | ||
| 'The symfony installer requires the php-curl extension or the ' |
ef91ce2 to
8e51180
Compare
| $handler = Utils::getDefaultHandler(); | ||
| } catch (\RuntimeException $e) { | ||
| throw new \RuntimeException( | ||
| 'The Symfony installer requires the php-curl extension or the ' |
There was a problem hiding this comment.
I don't think wrapping this message is the best idea for code style :)
There was a problem hiding this comment.
The linebreak? Removed it. It's < 120 characters wide. :)
8e51180 to
ea2c961
Compare
| $handler = Utils::getDefaultHandler(); | ||
| } catch (\RuntimeException $e) { | ||
| throw new \RuntimeException( | ||
| 'The Symfony installer requires the php-curl extension or the allow_url_fopen ini setting.'); |
There was a problem hiding this comment.
); should be on the next line, or keep everything inlined with the \RuntimeException constructor call.
ea2c961 to
3a5b5ca
Compare
| WORKDIR /root/shared | ||
| RUN apt-get update && apt-get install -y php5-cli | ||
|
|
||
| ENTRYPOINT /bin/bash |
There was a problem hiding this comment.
Is this really needed to have a dockerfile in this repo actually?
There was a problem hiding this comment.
Wow. I can't do this right.... I accidentally committed it. Really sorry... Removed.
When guzzle is initalized it tried to find a suitable handler to use. If no handler can be found (for example curl) an exception is thrown. With this change we try to find the handler before creating the client so we can pass the handler to the client manually. Doing this, we are able to customize the error message to make it (potentially) less confusing for the users who might have no idea what guzzle is.
3a5b5ca to
951732b
Compare
|
@emil-nasso I love it when an application displays meaningful error messages. Thanks for helping us improving the Installer error messages. |
javiereguiluz
added a commit
that referenced
this pull request
Dec 17, 2015
This PR was merged into the 1.0-dev branch. Discussion ---------- Intercept and customize error from Guzzle When guzzle is initalized it tries to find a suitable handler to use. If no handler can be found (for example curl) an exception is thrown. With this change we try to find the handler before creating the client so that we can pass the handler to the client manually. Doing this, we are able to customize the error message to make it (potentially) less confusing for the users who might have no idea what guzzle is. The issue was found when looking at PR #200 Commits ------- 951732b Intercept and customize error from Guzzle When guzzle is initalized it tried to find a suitable handler to use. If no handler can be found (for example curl) an exception is thrown. With this change we try to find the handler before creating the client so we can pass the handler to the client manually. Doing this, we are able to customize the error message to make it (potentially) less confusing for the users who might have no idea what guzzle is.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When guzzle is initalized it tries to find a suitable handler to use. If no handler can be found (for example curl) an exception is thrown.
With this change we try to find the handler before creating the client so that we can pass the handler to the client manually.
Doing this, we are able to customize the error message to make it (potentially) less confusing for the users who might have no idea what guzzle is.
The issue was found when looking at PR #200