Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Documented the logout_on_user_change option #9842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

This fixes #8428.

@iltar I need your help here. In your PR (https://github.com/symfony/symfony/pull/23882/files) you said:

This config item will trigger a logout when the user has changed.

I need more precision about what this means: "the user has changed". What exactly has changed? The token, the object that represents the user, some property of the user, etc. Thanks!

@linaori
Copy link
Contributor

linaori commented May 28, 2018

If the UserInterface implementation also implements the EquatableInterface and this function returns false, or when the actual getter return values do not match in the AbstractToken.

I think that was it 🤔

@javiereguiluz
Copy link
Member Author

@iltar thanks for those details! I've updated the description.

Copy link
Contributor

@linaori linaori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

javiereguiluz added a commit that referenced this pull request May 29, 2018
This PR was squashed before being merged into the 3.4 branch (closes #9842).

Discussion
----------

Documented the logout_on_user_change option

This fixes #8428.

@iltar I need your help here. In your PR (https://github.com/symfony/symfony/pull/23882/files) you said:

```
This config item will trigger a logout when the user has changed.
```

I need more precision about what this means: *"the user has changed"*. What exactly has changed? The token, the object that represents the user, some property of the user, etc. Thanks!

Commits
-------

68664a5 Documented the logout_on_user_change option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.