[Reference][Form] Describe the syntax of format option using a link of DateTimeType #9788
Conversation
|
Let's ping @vudaltsov as a Symfony Form expert to help us here. The PHPdoc of the DateTimeType class has a lot of information. Also, the ticket opened at ICU project was answered six years ago: http://icu-project.org/trac/ticket/9421 Can we review the PHPdoc of DateTimeType and see if it's still relevant or outdated? Thanks! |
|
The same link is used in DateType and BirthdayType docs. It comes from this template of this documentation. Depends on the answer of @vudaltsov, maybe it should be updated too. |
|
@javiereguiluz , I think we should create a separate issue to see if the PHPdoc is still relevant. |
|
Thanks for this improvement and congrats on your first Symfony Docs contribution! Thanks to reviewers too! |
…ing a link of DateTimeType (elementaire) This PR was merged into the 2.7 branch. Discussion ---------- [Reference][Form] Describe the syntax of format option using a link of DateTimeType I've added a link to describe how to write a valid format. It is the same link from date and birthday types. Commits ------- 8b361ef Update datetime.rst
|
Should i do something for this to be merged in recent versions of docs too? |
|
@elementaire there's no need to create new PRs. From time to time we merge all changes into the upper (maintained) branches. I've just do that, so your change is now in 2.7, 2.8, 3.4, 4.0, 4.1 and master. In a few hours, when symfony.com docs get rebuilt and caches expire, your change will be published. Cheers! |
|
Great :) |
I've added a link to describe how to write a valid format. It is the same link from date and birthday types.