Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add Sam in the core team #9497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2018
Merged

Add Sam in the core team #9497

merged 1 commit into from
Mar 26, 2018

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Mar 26, 2018

No description provided.

javiereguiluz
javiereguiluz reviewed Mar 26, 2018
View reviewed changes
contributing/code/core_team.rst Outdated
repositories.
repositories;

* **Samuel Roze** (`sroze`_) can merge into Messenger_ component.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo: Roze -> Rozé

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@javiereguiluz
Copy link
Member

Thanks Fabien.

@javiereguiluz javiereguiluz added this to the 2.7 milestone Mar 26, 2018
@javiereguiluz javiereguiluz merged commit 182aac8 into symfony:2.7 Mar 26, 2018
javiereguiluz added a commit that referenced this pull request Mar 26, 2018
@javiereguiluz
minor #9497 Add Sam in the core team (fabpot)
16de40d 
This PR was merged into the 2.7 branch.

Discussion
----------

Add Sam in the core team

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

182aac8 added Sam in the core team
@sroze
Copy link
Contributor

sroze commented Mar 26, 2018

Travis complained about the missing target though. I guess you need to add that at the end of the file:

 .. _`sroze`: https://github.com/sroze

:)

@javiereguiluz
Copy link
Member

Thanks! Fixed in 28377f7

xabbuh added a commit that referenced this pull request May 18, 2018
@xabbuh
[#9497] fix typo
b7ce0a9
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request May 20, 2018
@javiereguiluz
Merge branch '2.7' into 2.8
b74be85 
* 2.7:
  Use gender-neutral language in the main Serializer article
  [symfony#9497] fix typo
  Removed the term "simple" from creating a new page
  Update datetime.rst
  components/phpunit_bridge.rst
  Add best practice note about version
  Use is_numeric()
  [Console] Fix SymfonyStyle::ask usage
  Update BC policy to tell about adding/removing return types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@fabpot @javiereguiluz @sroze @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.