-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Markup in Config Validation example #9328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Feb 23, 2018
Much better now. Thanks! And congrats on your first Symfony Docs contribution. |
javiereguiluz
added a commit
that referenced
this pull request
Feb 24, 2018
This PR was merged into the 4.0 branch. Discussion ---------- Markup in Config Validation example With the previous markup, it is intuitively unclear what `->end()` is applied to `->validate()`. Commits ------- d823cbf Markup in validation example
@xabbuh I'm sorry but I didn't see the milestone you set up. I merged this in 4.0 instead of 2.7. Could you please fix my mistake? Thanks! |
xabbuh
pushed a commit
that referenced
this pull request
Feb 26, 2018
This PR was merged into the 4.0 branch. Discussion ---------- Markup in Config Validation example With the previous markup, it is intuitively unclear what `->end()` is applied to `->validate()`. Commits ------- d823cbf Markup in validation example
fixed in feb22f4 |
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Mar 1, 2018
* 2.7: Update forms.rst Add missing colon after protocol in link [Contributing] Reviewing an issue/pull-request (Giving constructive criticism) minor symfony#9328 Markup in Config Validation example (ProgMiner) Fix static method call Explaining the "one-to-many" case more explicitly
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Mar 1, 2018
* 2.8: Minor reword of the previous commit Update access_control.rst Update forms.rst Add missing colon after protocol in link [Contributing] Reviewing an issue/pull-request (Giving constructive criticism) minor symfony#9328 Markup in Config Validation example (ProgMiner) Fix static method call Explaining the "one-to-many" case more explicitly
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Mar 1, 2018
* 3.4: (23 commits) Update access_control.rst Update forms.rst Documented how to create lazy-loaded Twig extensions Add missing colon after protocol in link [Contributing] Reviewing an issue/pull-request (Giving constructive criticism) minor symfony#9328 Markup in Config Validation example (ProgMiner) Update service_container.rst Rename missing allowCustomResponseCode to correct allowCustomResponseCode Fix static method call Explaining the "one-to-many" case more explicitly fix console script path fixing second stopwatch example in phpunit-bridge docs fix console script path improve validation groups references ...
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Mar 1, 2018
* 4.0: (31 commits) Update framework.rst Update access_control.rst Update forms.rst Documented how to create lazy-loaded Twig extensions use diff code block Add missing colon after protocol in link Update flex.rst - Add step in migration-process Removed an extra blank line [Contributing] Reviewing an issue/pull-request (Giving constructive criticism) Update dbal.rst minor symfony#9328 Markup in Config Validation example (ProgMiner) Update service_container.rst Rename missing allowCustomResponseCode to correct allowCustomResponseCode Update requirements.rst Fix static method call Explaining the "one-to-many" case more explicitly ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous markup, it is intuitively unclear what
->end()
is applied to->validate()
.