Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Markup in Config Validation example #9328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2018
Merged

Markup in Config Validation example #9328

merged 1 commit into from
Feb 24, 2018

Conversation

ProgMiner
Copy link
Contributor

With the previous markup, it is intuitively unclear what ->end() is applied to ->validate().

@javiereguiluz
Copy link
Member

Much better now. Thanks! And congrats on your first Symfony Docs contribution.

@javiereguiluz javiereguiluz merged commit d823cbf into symfony:4.0 Feb 24, 2018
javiereguiluz added a commit that referenced this pull request Feb 24, 2018
This PR was merged into the 4.0 branch.

Discussion
----------

Markup in Config Validation example

With the previous markup, it is intuitively unclear what `->end()` is applied to `->validate()`.

Commits
-------

d823cbf Markup in validation example
@ProgMiner ProgMiner deleted the patch-1 branch February 24, 2018 15:39
@javiereguiluz
Copy link
Member

@xabbuh I'm sorry but I didn't see the milestone you set up. I merged this in 4.0 instead of 2.7. Could you please fix my mistake? Thanks!

@ProgMiner ProgMiner restored the patch-1 branch February 24, 2018 15:40
xabbuh pushed a commit that referenced this pull request Feb 26, 2018
This PR was merged into the 4.0 branch.

Discussion
----------

Markup in Config Validation example

With the previous markup, it is intuitively unclear what `->end()` is applied to `->validate()`.

Commits
-------

d823cbf Markup in validation example
@xabbuh
Copy link
Member

xabbuh commented Feb 26, 2018

fixed in feb22f4

javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Mar 1, 2018
* 2.7:
  Update forms.rst
  Add missing colon after protocol in link
  [Contributing] Reviewing an issue/pull-request (Giving constructive criticism)
  minor symfony#9328 Markup in Config Validation example (ProgMiner)
  Fix static method call
  Explaining the "one-to-many" case more explicitly
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Mar 1, 2018
* 2.8:
  Minor reword of the previous commit
  Update access_control.rst
  Update forms.rst
  Add missing colon after protocol in link
  [Contributing] Reviewing an issue/pull-request (Giving constructive criticism)
  minor symfony#9328 Markup in Config Validation example (ProgMiner)
  Fix static method call
  Explaining the "one-to-many" case more explicitly
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Mar 1, 2018
* 3.4: (23 commits)
  Update access_control.rst
  Update forms.rst
  Documented how to create lazy-loaded Twig extensions
  Add missing colon after protocol in link
  [Contributing] Reviewing an issue/pull-request (Giving constructive criticism)
  minor symfony#9328 Markup in Config Validation example (ProgMiner)
  Update service_container.rst
  Rename missing allowCustomResponseCode to correct allowCustomResponseCode
  Fix static method call
  Explaining the "one-to-many" case more explicitly
  fix console script path
  fixing second stopwatch example in phpunit-bridge docs
  fix console script path
  improve validation groups references
  ...
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Mar 1, 2018
* 4.0: (31 commits)
  Update framework.rst
  Update access_control.rst
  Update forms.rst
  Documented how to create lazy-loaded Twig extensions
  use diff code block
  Add missing colon after protocol in link
  Update flex.rst - Add step in migration-process
  Removed an extra blank line
  [Contributing] Reviewing an issue/pull-request (Giving constructive criticism)
  Update dbal.rst
  minor symfony#9328 Markup in Config Validation example (ProgMiner)
  Update service_container.rst
  Rename missing allowCustomResponseCode to correct allowCustomResponseCode
  Update requirements.rst
  Fix static method call
  Explaining the "one-to-many" case more explicitly
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.