Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

remove old versionadded directives #9325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2018
Merged

remove old versionadded directives #9325

merged 1 commit into from
Feb 23, 2018

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 23, 2018

same as d038da7

@xabbuh xabbuh added this to the 4.0 milestone Feb 23, 2018
@xabbuh
Copy link
Member Author

xabbuh commented Feb 23, 2018

I think we should simplify the process for removing versionadded directives (currently document at http://symfony.com/doc/current/contributing/documentation/format.html#new-features-or-behavior-changes) and just always drop all existing versionadded directives when a new major version is released. What do you think?

@javiereguiluz javiereguiluz mentioned this pull request Feb 23, 2018
Merged
javiereguiluz added a commit that referenced this pull request Feb 23, 2018
@javiereguiluz
minor #9327 Fixed a versionadded directive (javiereguiluz)
3498aa9 
This PR was merged into the 3.4 branch.

Discussion
----------

Fixed a versionadded directive

Spotted while reviewing #9325.

Commits
-------

6be33f6 Fixed a versionadded directive
@javiereguiluz
Copy link
Member

javiereguiluz commented Feb 23, 2018 •
edited
Loading

Thanks Christian! I agree with your proposal about simplifying the removal of versionadded directives.

@javiereguiluz javiereguiluz merged commit 2a78bb9 into symfony:4.0 Feb 23, 2018
javiereguiluz added a commit that referenced this pull request Feb 23, 2018
@javiereguiluz
minor #9325 remove old versionadded directives (xabbuh)
1a7f714 
This PR was merged into the 4.0 branch.

Discussion
----------

remove old versionadded directives

same as d038da7

Commits
-------

2a78bb9 remove old versionadded directives
@xabbuh xabbuh deleted the versionadded branch February 23, 2018 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @javiereguiluz @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.