[FrameworkBundle] PR #26213 Document redirections with 307/308 HTTP status codes #9298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
reviewed
Feb 20, 2018
routing/redirect_in_config.rst
Outdated
| Redirecting POST/PUT calls | ||
| -------------------------- | ||
|
|
||
| As default behaviour of both methods mentioned above results in sending |
Simperfit
reviewed
Feb 20, 2018
routing/redirect_in_config.rst
Outdated
|
|
||
| return $collection; | ||
|
|
||
| Switching ``keepRequestMethod`` switch to ``true`` will result in sending |
There was a problem hiding this comment.
When keepRequestMethod is set to true with either permanent set to false which will lead to a 307 response or 308 with permanent being true. Theses codes will give information in the HTTP request that the method should be repeated without altering the body.
Simperfit
reviewed
Feb 20, 2018
routing/redirect_in_config.rst
Outdated
| use Symfony\Component\Routing\Route; | ||
|
|
||
| $collection = new RouteCollection(); | ||
| // ... |
Simperfit
reviewed
Feb 20, 2018
routing/redirect_in_config.rst
Outdated
| xsi:schemaLocation="http://symfony.com/schema/routing | ||
| http://symfony.com/schema/routing/routing-1.0.xsd"> | ||
|
|
||
| <!-- ... --> |
Simperfit
reviewed
Feb 20, 2018
routing/redirect_in_config.rst
Outdated
|
|
||
| # config/routes.yaml | ||
|
|
||
| # ... |
Simperfit
reviewed
Feb 20, 2018
routing/redirect_in_config.rst
Outdated
|
|
||
| As default behaviour of both methods mentioned above results in sending | ||
| response with ``301`` or ``302`` HTTP status codes, the following call will | ||
| be made with use of HTTP request method. But it some scenarios it is |
There was a problem hiding this comment.
use of HTTP request method
WDYM ?
But it some scenarios
But in some scenarios it's either expected or required that the following call [...]
|
Thank you @Simperfit - all changes applied |
I did some rewords based on https://symfony.com/blog/new-in-symfony-4-1-307-and-308-redirections and added a full config example.
|
@ZipoKing thanks for contributing the docs for this nice feature that you also contributed ... and congrats on your first Symfony Docs contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Mar 5, 2018
…7/308 HTTP status codes (ZipoKing, javiereguiluz) This PR was merged into the master branch. Discussion ---------- [FrameworkBundle] PR #26213 Document redirections with 307/308 HTTP status codes This documents changes introduced with pull request symfony/symfony#26213 Commits ------- 9468bf9 Reword and added an example c8ce65d Changes after @Simperfit review b3984d0 [PR #26213 Document redirections with 307/308 HTTP status codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents changes introduced with pull request symfony/symfony#26213