Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Refactored the CSRF docs #8873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 28, 2017
Merged

Refactored the CSRF docs #8873

merged 4 commits into from
Dec 28, 2017

Conversation

javiereguiluz
Copy link
Member

This fixes #8868.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing because </form/csrf_protection> in http_cache/form_csrf_caching.rst is not yet up to date with the new reference.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

fabpot added a commit to symfony/symfony that referenced this pull request Dec 14, 2017
This PR was merged into the 3.4 branch.

Discussion
----------

Fixing wrong class_exists on interface

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | symfony/symfony-docs#8873 already does not mention changing anything in the config

This was a bug introduced in #25151 on the 3.4 branch. It's... pretty self-explanatory I hope :).

Cheers!

Commits
-------

be75bd9 Fixing wrong class_exists on interface
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Dec 14, 2017
This PR was merged into the 3.4 branch.

Discussion
----------

Fixing wrong class_exists on interface

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | symfony/symfony-docs#8873 already does not mention changing anything in the config

This was a bug introduced in #25151 on the 3.4 branch. It's... pretty self-explanatory I hope :).

Cheers!

Commits
-------

be75bd994b Fixing wrong class_exists on interface

.. note::
CSRF protection works by adding a hidden field to your form that contains a
value that only you and your user knows. This ensures that the user - not some
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

know

@xabbuh xabbuh added this to the 4.0 milestone Dec 22, 2017
@weaverryan weaverryan merged commit 5300c20 into symfony:4.0 Dec 28, 2017
weaverryan added a commit that referenced this pull request Dec 28, 2017
This PR was squashed before being merged into the 4.0 branch (closes #8873).

Discussion
----------

Refactored the CSRF docs

This fixes #8868.

Commits
-------

5300c20 Fixed a grammar error
ec3f769 Fixed another reference
9173ac9 Fixed some internal references
187c836 Refactored the CSRF docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.