Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Updates in performance.rst #8410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Updates in performance.rst #8410

wants to merge 11 commits into from

Conversation

Erdou
Copy link
Contributor

@Erdou Erdou commented Sep 19, 2017

…with generated APCu loader

@xabbuh
Copy link
Member

xabbuh commented Sep 20, 2017

Thank you for your first contribution @Erdou. You are absolutely right with the changes you propose. However, I am afraid that this greatly overlaps with the ongoing work from #7960. Maybe you would like to merge your changes with the changes done by @javiereguiluz?

@javiereguiluz Or should we merge here and you rebase your changes on top of that?

@Erdou
Copy link
Contributor Author

Erdou commented Sep 20, 2017

Thank you for your feedback @xabbuh
I'll merge here, then @javiereguiluz can take it back :)

@Erdou Erdou changed the title Update performance.rst for Sf3: replaced deprecated APC class loader … Updates in performance.rst Sep 20, 2017
@Erdou
Copy link
Contributor Author

Erdou commented Sep 20, 2017

@xabbuh @javiereguiluz Merge done and I also improved a few minor stuff, but Travis is not happy and I cannot understand why. A little help will be appreciated here :)

@javiereguiluz
Copy link
Member

@Erdou the error comes from this change:

error

The single: ... thing is part of the .. index:: directive and must be indented.

@Erdou
Copy link
Contributor Author

Erdou commented Sep 21, 2017

@javiereguiluz Thanks it passes now :)
I let you and @xabbuh take it from here. Don't hesitate to tell me if I can help more
And sorry for the fuzzy merge, it was my first time merging and commiting into a Github PR

@xabbuh
Copy link
Member

xabbuh commented Oct 11, 2017

@javiereguiluz Can you have a look here?

weaverryan added a commit that referenced this pull request Oct 29, 2017
This PR was merged into the 3.3 branch.

Discussion
----------

Remove outdated performance tips

I've just realized there is an ongoing effort to rewrite this in #8410 and #7960.
But if those are not merged soon, I'd suggest to merge this first so that we can at least solve the broken doc and people don't try to repeatedly fix this, like me and #8332

Commits
-------

d21e200 Remove outdated performance tips
@javiereguiluz
Copy link
Member

Closing it in favor of #9161.

javiereguiluz added a commit that referenced this pull request Jan 30, 2018
…onable (javiereguiluz)

This PR was squashed before being merged into the 2.7 branch (closes #9161).

Discussion
----------

Updated the main performance article to make it more actionable

This one finishes and replaces #7960, #8410 and #8332.

Commits
-------

fa393c5 Updated the main performance article to make it more actionable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.