From e74e5562ca4c6dc50f6ee1d180509084a62ac311 Mon Sep 17 00:00:00 2001 From: Bogdan Olteanu Date: Sun, 18 Jun 2017 16:45:54 +0300 Subject: [PATCH 1/3] Added the command to install babel-preset for babel-loader While testing this bundle i was getting hit by an erorr that i can't find the babel preset es2017 which i solved it by installing. I'm new to this webpack thing and to work like this with javascript. Some people might be in my position and try for hours to solve this. :D --- frontend/encore/babel.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/frontend/encore/babel.rst b/frontend/encore/babel.rst index 0fd00cc2c6d..d8d75fb85b6 100644 --- a/frontend/encore/babel.rst +++ b/frontend/encore/babel.rst @@ -7,6 +7,10 @@ Configuring Babel Need to extend the Babel configuration further? The easiest way is via ``configureBabel()``: +But first let's install the babel preset. + +``yarn add babel-preset-es2017`` +This will install the preset that we will use later to configure the babel. .. code-block:: javascript From ab41bafceb6c349c8863cbf6a2d1b6b493e98db7 Mon Sep 17 00:00:00 2001 From: Bogdan Olteanu Date: Sun, 18 Jun 2017 19:56:19 +0300 Subject: [PATCH 2/3] Update babel.rst --- frontend/encore/babel.rst | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/frontend/encore/babel.rst b/frontend/encore/babel.rst index d8d75fb85b6..1dbc6b4f775 100644 --- a/frontend/encore/babel.rst +++ b/frontend/encore/babel.rst @@ -7,10 +7,6 @@ Configuring Babel Need to extend the Babel configuration further? The easiest way is via ``configureBabel()``: -But first let's install the babel preset. - -``yarn add babel-preset-es2017`` -This will install the preset that we will use later to configure the babel. .. code-block:: javascript @@ -19,7 +15,9 @@ This will install the preset that we will use later to configure the babel. Encore // ... - + + // make sure to install any presets you want to use + // yarn add babel-preset-es2017 // modify the default Babel configuration .configureBabel(function(babelConfig) { babelConfig.presets.push('es2017'); From b9edef8ef405dc6567ce1cefe43ce7d4d639ace2 Mon Sep 17 00:00:00 2001 From: Javier Eguiluz Date: Sun, 9 Jul 2017 17:10:21 +0200 Subject: [PATCH 3/3] Minor reword --- frontend/encore/babel.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/frontend/encore/babel.rst b/frontend/encore/babel.rst index 1dbc6b4f775..ae2b33a79c5 100644 --- a/frontend/encore/babel.rst +++ b/frontend/encore/babel.rst @@ -16,9 +16,8 @@ Need to extend the Babel configuration further? The easiest way is via Encore // ... - // make sure to install any presets you want to use - // yarn add babel-preset-es2017 - // modify the default Babel configuration + // first, install any presets you want to use (e.g. yarn add babel-preset-es2017) + // then, modify the default Babel configuration .configureBabel(function(babelConfig) { babelConfig.presets.push('es2017'); })