Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Encore tweaks! #8035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Encore tweaks! #8035

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5f815e6
Tweaks thanks to @bocharsky-bw
weaverryan Jun 13, 2017
3377b92
re-ordering indexes, so that next goes into Encore
weaverryan Jun 13, 2017
2017e5a
tweak
weaverryan Jun 13, 2017
ce95648
making sure some articles are ordered
weaverryan Jun 13, 2017
17cd8e9
Making title more specific
weaverryan Jun 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tweak
  • Loading branch information
@weaverryan
weaverryan committed Jun 13, 2017
commit 2017e5ac671beeb153154ea4be4583e3388b8c9d
1 change: 1 addition & 0 deletions 1 frontend/encore/simple-example.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ Above, you created an entry called ``app`` that pointed to ``main.js``:
Encore
// ...
.addEntry('app', './assets/js/main.js')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing semicolon

Copy link
Contributor

@sstok sstok Jun 13, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's on the next line, and JavaScript will work just fine here 😛

But don't leave a trailing comma for better diff readability!, oh God no, we can't have that!! the Angels will the weep the blood of innocent, the sky will fall down like ashes, the seas will boil, the land will be engulfed with hordes of flies, chaos will rule the land for a 1000 years, nothing will ever grow anymore, all is dead. And.... ahhh, the compiler will fail to work 😑 JavaScript - forgives a missing semi-colon (when there is a space), but chokes on a trailing comma (because accepting that would be blasphemy).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure it wasn't there when I commented. :)

;

Once inside ``main.js``, you can even require CSS files:

Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.