Added a note about deprecating addClassesToCompile() #7819
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Apr 19, 2017
bundles/extension.rst
Outdated
| @@ -129,6 +129,11 @@ read more about it, see the ":doc:`/bundles/configuration`" article. | ||
| Adding Classes to Compile | ||
| ------------------------- | ||
|
|
||
| .. versionadded:: 3.3 | ||
| This technique is discouraged and the ``addClassesToCompile()`` has been |
There was a problem hiding this comment.
I think we should reword this a bit as when #7193 is merged, we will also explain the addAnnotatedClassesToCompile() method in this section.
There was a problem hiding this comment.
I don't know what to do here. What were you thinking exactly? Thanks!
xabbuh
approved these changes
Oct 8, 2017
afbce94 to
16b7585
Compare
xabbuh
added a commit
that referenced
this pull request
Oct 13, 2017
This PR was merged into the 3.3 branch. Discussion ---------- Deprecated loadClassCache() method This fixes #7337. I didn't found any other occurrence of the deprecated classes/methods mentioned in the related issue. In #7819 we're taking care of the deprecation of `addClassesToCompile()`. Commits ------- 7e7a945 Deprecated loadClassCache() method
|
Thank you Javier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7815.