last tweaks from feedback

symfony · weaverryan · May 5, 2017 · Apr 15, 2017 · Apr 28, 2017 · Apr 28, 2017
commit 759e9b2305e8247147f9946c3763930587553dcc
diff --git a/service_container.rst b/service_container.rst
@@ -142,9 +142,9 @@ the service container *how* to instantiate it:
        // app/config/services.php
        TODO

-That's it! Thanks to the ``AppBundle\`` line and ``resource`` key below it, all
-classes in the ``src/AppBundle/Service`` directory (and a few other directories)
-will automatically be added to the container.
+That's it! Thanks to the ``AppBundle\`` line and ``resource`` key below it, a service
+will be registered for each class in the ``src/AppBundle/Service`` directory (and
+the other directories listed).

 Each service's "key" is its class name. You can use it immediately inside your controller::

@@ -210,11 +210,11 @@ and set it on a ``$logger`` property::
    }

 That's it! The container will *automatically* know to pass the ``logger`` service
-when instantiating the ``MessageGenerator``? How does it know to do this?
+when instantiating the ``MessageGenerator``. How does it know to do this?
 :doc:`Autowiring </service_container/autowiring>`. The key is the ``LoggerInterface``
 type-hint in your ``__construct()`` method and the ``autowire: true`` config in
 ``services.yml``. When you type-hint an argument, the container will automatically
-find the matching service. If it can't or there is any ambuiguity, you'll see a clear
+find the matching service. If it can't or there is any ambiguity, you'll see a clear
 exception suggesting how to fix it.

 Be sure to read more about :doc:`autowiring </service_container/autowiring>`.
-Original file line number
+Diff line change
@@ -142,9 +142,9 @@ the service container *how* to instantiate it:
             // app/config/services.php
             TODO
             Copy link

  
      
    
  

  
      

  
    Contributor


      

  

  
    
      

      
            GuilhemN
  

      

      

      


        Apr 28, 2017


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      Prototypes don't exist for php code so imo we should either remove this doc block or let the current one with a comment explaining that it's not possible to register entire folders as with other loaders.
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
-    That's it! Thanks to the ``AppBundle\`` line and ``resource`` key below it, all
-    classes in the ``src/AppBundle/Service`` directory (and a few other directories)
-    will automatically be added to the container.
+    That's it! Thanks to the ``AppBundle\`` line and ``resource`` key below it, a service
+    will be registered for each class in the ``src/AppBundle/Service`` directory (and
+    the other directories listed).
     Each service's "key" is its class name. You can use it immediately inside your controller::
             Copy link

  
      
    
  

  
      

  
    Contributor


      

  

  
    
      

      
            GuilhemN
  

      

      

      


        Apr 28, 2017


      
  •

  
    
      
        
          edited
          
        
        
      
    
    
      
  
        
      Loading


  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  
    
  


    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      id? or identifier if we want to be precise?
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
@@ -210,11 +210,11 @@ and set it on a ``$logger`` property::
         }
     That's it! The container will *automatically* know to pass the ``logger`` service
-    when instantiating the ``MessageGenerator``? How does it know to do this?
+    when instantiating the ``MessageGenerator``. How does it know to do this?
     :doc:`Autowiring </service_container/autowiring>`. The key is the ``LoggerInterface``
     type-hint in your ``__construct()`` method and the ``autowire: true`` config in
     ``services.yml``. When you type-hint an argument, the container will automatically
-    find the matching service. If it can't or there is any ambuiguity, you'll see a clear
+    find the matching service. If it can't or there is any ambiguity, you'll see a clear
             Copy link

  
      
    
  

  
      

  
  Member


      

  

  
    
      

      
            nicolas-grekas
  

      

      

      


        Apr 28, 2017


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      there won't be ambiguities anymore for interfaces (interfaces can be autowired by aliasing only now, when not using the deprecated mode). Dunno how that applies here :)
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
     exception suggesting how to fix it.
     Be sure to read more about :doc:`autowiring </service_container/autowiring>`.
-          Expand Down