Documentation for Cookie::fromString #7313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated.. removed the additional tip on low-level api usage; i agree with @javiereguiluz on this. So basically we simply mention |
HeahDude
reviewed
Apr 19, 2017
javiereguiluz
approved these changes
Apr 24, 2017
|
Roland thanks for your first contribution to Symfony Docs and thanks for your great patience during the review process! |
javiereguiluz
added a commit
that referenced
this pull request
Apr 24, 2017
This PR was merged into the master branch. Discussion ---------- Documentation for Cookie::fromString See #7278 First time, be patient :) There's also 2nd argument in `fromString` controlling URL decoding, implying `Cookie::isRaw`, but i tend to leave it an implementation detail. Commits ------- 91329f4 Add method parenthesis 09e27fa version added e233519 derp a909e28 feedback 86fa70b Update http_foundation.rst
This was referenced Apr 24, 2017
javiereguiluz
added a commit
that referenced
this pull request
Apr 24, 2017
This PR was merged into the master branch. Discussion ---------- Fixed a minor syntax issue After merging #7313, Travis reported a minor syntax issue: the backslashes here weren't escaped: ``` :method:`Symfony\Component\HttpFoundation\Cookie::fromString` ``` Commits ------- 074ff88 Fixed a minor syntax issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7278
First time, be patient :)
There's also 2nd argument in
fromStringcontrolling URL decoding, implyingCookie::isRaw, but i tend to leave it an implementation detail.